Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Do not uninstall package on reinstall error #171880

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Nov 23, 2023

Summary

We currently uninstalling package on reinstall error, it seems to me it's a dangerous behaviour, reinstall can come from an automation like upgrading kibana, and I think uninstalling the package in this case can make things worse, and we probably should keep the package and mark it as install_failed, (this is what happening when a rollback after an upgrade fail for example)

Also we are going to show install_failed in installed integrations (Related issue here) we will be able to show those errors to the user.

@nchaulet nchaulet requested a review from a team as a code owner November 23, 2023 16:26
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 23, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet marked this pull request as draft November 23, 2023 16:26
@nchaulet nchaulet added the release_note:skip Skip the PR/issue when compiling release notes label Nov 23, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@nchaulet nchaulet force-pushed the feature-fix-reinstall-error-handling branch from ffa572c to dee3a5b Compare November 23, 2023 17:58
@nchaulet nchaulet marked this pull request as ready for review November 27, 2023 15:36
@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nchaulet nchaulet merged commit e7478d5 into elastic:main Nov 27, 2023
31 checks passed
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 27, 2023
@nchaulet nchaulet deleted the feature-fix-reinstall-error-handling branch November 27, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants