Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adds capabilities and ML node check to create job button in dashboard #172022

Merged
merged 7 commits into from Dec 1, 2023
Merged

[ML] Adds capabilities and ML node check to create job button in dashboard #172022

merged 7 commits into from Dec 1, 2023

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Nov 27, 2023 •
edited

Fixes #163575
When no jobs are available for selection the Create job button should be disabled for users who cannot create jobs and when no ML nodes are available.

When user has insufficient permissions
image

When no ML nodes are available
image

@jgowdyelastic jgowdyelastic self-assigned this Nov 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic requested a review from a team as a code owner November 27, 2023 20:16
peteharverson
peteharverson reviewed Nov 28, 2023
View reviewed changes
...ugins/ml/public/application/components/job_selector/job_selector_table/job_selector_table.js
application: { navigateToApp },
application: {
navigateToApp,
capabilities: { ml: mlCapabilities },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, to close off #163575 we also need to add a check for ML nodes being available.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in dae614e

@jgowdyelastic jgowdyelastic changed the title [ML] Adding capabilities check to create job button in dashboard [ML] Adding capabilities and ML node check to create job button in dashboard Nov 28, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.6MB 3.6MB +139.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

peteharverson
peteharverson approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes for ML node check and LGTM

@jgowdyelastic jgowdyelastic merged commit 1598ed8 into elastic:main Dec 1, 2023
35 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 1, 2023
@szabosteve szabosteve changed the title [ML] Adding capabilities and ML node check to create job button in dashboard [ML] Adds capabilities and ML node check to create job button in dashboard Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@jgowdyelastic jgowdyelastic

Labels
backport:skip This commit does not require backporting Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Links to new job wizards should contains checks for available ML nodes
5 participants
@jgowdyelastic @elasticmachine @kibana-ci @peteharverson @kibanamachine