Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Make the dashboard SO lighter #172130

Merged
merged 3 commits into from Nov 29, 2023
Merged

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Nov 29, 2023

Summary

This PR makes the dashboard SO lighter by removing the initialContext from the state. It is not needed after the navigation from Discover to Dashboard and can create SO size problems as it contains a lot of information for the transition.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.4MB 1.4MB +22.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added release_note:fix Feature:ES|QL backport:prev-minor Backport to the previous minor version (i.e. one version back from main) Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.12.0 v8.11.2 labels Nov 29, 2023
@stratoula stratoula marked this pull request as ready for review November 29, 2023 08:53
@stratoula stratoula requested a review from a team as a code owner November 29, 2023 08:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only 👍

@stratoula stratoula merged commit cb3fd21 into elastic:main Nov 29, 2023
41 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.11 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 172130

Questions ?

Please refer to the Backport tool documentation

stratoula added a commit to stratoula/kibana that referenced this pull request Nov 29, 2023
## Summary

This PR makes the dashboard SO lighter by removing the initialContext
from the state. It is not needed after the navigation from Discover to
Dashboard and can create SO size problems as it contains a lot of
information for the transition.

(cherry picked from commit cb3fd21)

# Conflicts:
#	x-pack/plugins/lens/public/datasources/text_based/text_based_languages.test.ts
@stratoula
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

stratoula added a commit that referenced this pull request Nov 29, 2023
# Backport

This will backport the following commits from `main` to `8.11`:
- [[ES|QL] Make the dashboard SO lighter
(#172130)](#172130)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2023-11-29T10:55:21Z","message":"[ES|QL]
Make the dashboard SO lighter (#172130)\n\n## Summary\r\n\r\nThis PR
makes the dashboard SO lighter by removing the initialContext\r\nfrom
the state. It is not needed after the navigation from Discover
to\r\nDashboard and can create SO size problems as it contains a lot
of\r\ninformation for the
transition.","sha":"cb3fd2132f47d43e4d46b8f5b085195cb8dda806","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","backport:prev-minor","Feature:ES|QL","v8.12.0","v8.11.2"],"number":172130,"url":"#172130
Make the dashboard SO lighter (#172130)\n\n## Summary\r\n\r\nThis PR
makes the dashboard SO lighter by removing the initialContext\r\nfrom
the state. It is not needed after the navigation from Discover
to\r\nDashboard and can create SO size problems as it contains a lot
of\r\ninformation for the
transition.","sha":"cb3fd2132f47d43e4d46b8f5b085195cb8dda806"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"#172130
Make the dashboard SO lighter (#172130)\n\n## Summary\r\n\r\nThis PR
makes the dashboard SO lighter by removing the initialContext\r\nfrom
the state. It is not needed after the navigation from Discover
to\r\nDashboard and can create SO size problems as it contains a lot
of\r\ninformation for the
transition.","sha":"cb3fd2132f47d43e4d46b8f5b085195cb8dda806"}},{"branch":"8.11","label":"v8.11.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) Feature:ES|QL release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.11.2 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants