Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified Search] [Lens] [Dashboard Controls] Middle truncation for data view pickers and field lists #172296

Merged
merged 3 commits into from Dec 1, 2023
Merged

[Unified Search] [Lens] [Dashboard Controls] Middle truncation for data view pickers and field lists #172296

merged 3 commits into from Dec 1, 2023

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Nov 30, 2023 •
edited

Adds middle truncation to the following:
Fixes #168753
Fixes #170398

Unified Search:
Screenshot 2023-11-30 at 16 06 49

Lens layer data view picker:
Screenshot 2023-11-30 at 16 06 58

Create control field list:
Screenshot 2023-11-30 at 16 15 12

Create control data view list:

Screenshot 2023-11-30 at 16 33 10

@mbondyra mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens Feature:Unified search Unified search related tasks labels Nov 30, 2023
@mbondyra mbondyra marked this pull request as ready for review November 30, 2023 16:07
@mbondyra mbondyra requested review from a team as code owners November 30, 2023 16:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
presentationUtil 82.4KB 82.5KB +88.0B
unifiedSearch 214.9KB 215.6KB +702.0B
total +790.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
unifiedSearch 35.4KB 35.5KB +66.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Heenawter Heenawter self-requested a review November 30, 2023 23:17
@stratoula stratoula added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Dec 1, 2023
@stratoula
Copy link
Contributor

I changed it to an enhancement because I think is a nice improvement and should be on our release notes.

stratoula
stratoula approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unified search changes LGTM!

@mbondyra mbondyra enabled auto-merge (squash) December 1, 2023 15:15
Heenawter
Heenawter approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for tackling the changes in Presentation Util! Code review + quick local test. This works great 🎉

@mbondyra mbondyra merged commit d83955d into elastic:main Dec 1, 2023
33 checks passed
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heenawter Heenawter Heenawter approved these changes

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens Feature:Unified search Unified search related tasks release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dashboard][Controls] Fix field truncation on EuiSelectable Fix field truncation on Combo boxes
6 participants
@mbondyra @elasticmachine @kibana-ci @stratoula @Heenawter @kibanamachine