Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs Explorer] Update breadcrumbs content for Log Explorer app #172612

Merged

Conversation

thomheymann
Copy link
Contributor

@thomheymann thomheymann commented Dec 5, 2023

Resolves #172283

Summary

Fixes breadcrumbs and document title for Log Explorer app.

Screenshot

Screenshot 2023-12-05 at 17 29 53

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@thomheymann thomheymann marked this pull request as ready for review December 6, 2023 09:01
@thomheymann thomheymann requested a review from a team as a code owner December 6, 2023 09:01
@tonyghiani tonyghiani added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team Feature:LogsExplorer Logs Explorer feature and removed release_note:fix labels Dec 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@tonyghiani tonyghiani changed the title Update breadcrumbs content for Log Explorer app [Logs Explorer] Update breadcrumbs content for Log Explorer app Dec 7, 2023
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, congrats on your first Logs contribution! 👏 👏 👏

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityLogExplorer 131 132 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/deeplinks-observability 16 19 +3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityLogExplorer 32.1KB 32.5KB +472.0B
Unknown metric groups

API count

id before after diff
@kbn/deeplinks-observability 26 29 +3

ESLint disabled line counts

id before after diff
observabilityLogExplorer 1 2 +1

Total ESLint disabled count

id before after diff
observabilityLogExplorer 1 2 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomheymann thomheymann merged commit fd5256a into elastic:main Dec 7, 2023
36 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:LogsExplorer Logs Explorer feature release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs Explorer] Update breadcrumbs content for Log Explorer app
6 participants