[Synthetics] Remove legacy screenshot image codepath #172684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
bug
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
justinkambic
force-pushed
the
remove-legacy-screenshot-codepath
branch
2 times, most recently
from
7f82759
to
8b3cece
Compare
shahzad31
approved these changes
Dec 7, 2023
justinkambic
force-pushed
the
remove-legacy-screenshot-codepath
branch
from
8b3cece
to
72342f2
Compare
justinkambic
force-pushed
the
remove-legacy-screenshot-codepath
branch
from
aa946c6
to
36f2aef
Compare
mykolaharmash
approved these changes
Dec 8, 2023
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 8, 2023
## Summary We have not used full screenshot image data since early alpha versions of Synthetics, and there is no reason to _not_ use screenshot blocks instead as they make far more efficient storage performance. Removes the route that returns full image data. I may later include changes to remove references to this on the client as well, or do that in a follow-up. (cherry picked from commit 8d3e8cd)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 8, 2023
…#172980) # Backport This will backport the following commits from `main` to `8.12`: - [[Synthetics] Remove legacy screenshot image codepath (#172684)](#172684) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Justin Kambic","email":"jk@elastic.co"},"sourceCommit":{"committedDate":"2023-12-08T17:13:45Z","message":"[Synthetics] Remove legacy screenshot image codepath (#172684)\n\n## Summary\r\n\r\nWe have not used full screenshot image data since early alpha versions\r\nof Synthetics, and there is no reason to _not_ use screenshot blocks\r\ninstead as they make far more efficient storage performance.\r\n\r\nRemoves the route that returns full image data. I may later include\r\nchanges to remove references to this on the client as well, or do that\r\nin a follow-up.","sha":"8d3e8cd838ad80f8955c986fe830a9e6590a60de","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v8.12.0","Team:obs-ux-infra_services","Team:uptime","v8.13.0"],"number":172684,"url":"#172684 Remove legacy screenshot image codepath (#172684)\n\n## Summary\r\n\r\nWe have not used full screenshot image data since early alpha versions\r\nof Synthetics, and there is no reason to _not_ use screenshot blocks\r\ninstead as they make far more efficient storage performance.\r\n\r\nRemoves the route that returns full image data. I may later include\r\nchanges to remove references to this on the client as well, or do that\r\nin a follow-up.","sha":"8d3e8cd838ad80f8955c986fe830a9e6590a60de"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"#172684 Remove legacy screenshot image codepath (#172684)\n\n## Summary\r\n\r\nWe have not used full screenshot image data since early alpha versions\r\nof Synthetics, and there is no reason to _not_ use screenshot blocks\r\ninstead as they make far more efficient storage performance.\r\n\r\nRemoves the route that returns full image data. I may later include\r\nchanges to remove references to this on the client as well, or do that\r\nin a follow-up.","sha":"8d3e8cd838ad80f8955c986fe830a9e6590a60de"}}]}] BACKPORT--> Co-authored-by: Justin Kambic <jk@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have not used full screenshot image data since early alpha versions of Synthetics, and there is no reason to not use screenshot blocks instead as they make far more efficient storage performance.
Removes the route that returns full image data. I may later include changes to remove references to this on the client as well, or do that in a follow-up.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers