Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.11] Revert "fix/142865/path.data config unused (#158426)" #172943

Merged
merged 1 commit into from Dec 8, 2023
Merged

[8.11] Revert "fix/142865/path.data config unused (#158426)" #172943

merged 1 commit into from Dec 8, 2023

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Dec 8, 2023 •
edited

This reverts commit 86d2f58.

#172919

Release note:
Fixes an issue where running kibana-keystore commands required kibana.yml to exist.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

Documentation preview:

@jbudz
Copy link
Member Author

jbudz commented Dec 8, 2023

buildkite test this

@jbudz jbudz marked this pull request as ready for review December 8, 2023 14:24
@jbudz jbudz added backport release_note:fix Team:Operations Team label for Operations Team and removed backport labels Dec 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz jbudz added the v8.11.3 label Dec 8, 2023
@delanni delanni self-requested a review December 8, 2023 14:26
@delanni delanni mentioned this pull request Dec 8, 2023
Merged
@jbudz
Copy link
Member Author

jbudz commented Dec 8, 2023 •
edited

‼️ ERROR: no builds found for mergeBase sha [https://github.com/elastic/kibana/commit/645d402a1c2908dd01d445555684747b423bec9b]

The 8.11 branch was shut off, so we're missing metrics for the commit this is based on. The branch is turned back on with 760b692 and I restarted metrics collection with https://buildkite.com/elastic/kibana-on-merge/builds/39110.

Rebuilding shortly, once the on-merge build progresses enough to collect metrics.

@jbudz jbudz mentioned this pull request Dec 8, 2023
Merged
@jbudz jbudz changed the title Revert "fix/142865/path.data config unused (#158426)" [8.11] Revert "fix/142865/path.data config unused (#158426)" Dec 8, 2023
@jbudz
Copy link
Member Author

jbudz commented Dec 8, 2023

buildkite test this

jbudz added a commit that referenced this pull request Dec 8, 2023
@jbudz
Revert "fix/142865/path.data config unused (#158426)" (#172951)
ee194d3 
This reverts commit 86d2f58.

Forward port of #172943 targeting
8.13 and 8.12. See the linked pr for 8.11.3 release notes.

Closes #172919
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/utils 15 14 -1
Unknown metric groups

API count

id before after diff
@kbn/utils 25 24 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit cc11667 into elastic:8.11 Dec 8, 2023
24 of 25 checks passed
kibanamachine pushed a commit that referenced this pull request Dec 8, 2023
@jbudz
Revert "fix/142865/path.data config unused (#158426)" (#172951)
34bfd1d 
This reverts commit 86d2f58.

Forward port of #172943 targeting
8.13 and 8.12. See the linked pr for 8.11.3 release notes.

Closes #172919

(cherry picked from commit ee194d3)
kibanamachine added a commit that referenced this pull request Dec 19, 2023
@kibanamachine @jbudz @Ikuni17
[8.12] Revert "fix/142865/path.data config unused (#158426)" (#172951) (
79a0f48 
#172970)

# Backport

This will backport the following commits from `main` to `8.12`:
- [Revert "fix/142865/path.data config unused (#158426)"
(#172951)](#172951)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jon","email":"jon@elastic.co"},"sourceCommit":{"committedDate":"2023-12-08T16:22:21Z","message":"Revert
\"fix/142865/path.data config unused (#158426)\" (#172951)\n\nThis
reverts commit 86d2f58.\r\n\r\nForward
port of #172943 targeting\r\n8.13
and 8.12. See the linked pr for 8.11.3 release notes.\r\n\r\nCloses
#172919
\"fix/142865/path.data config unused (#158426)\" (#172951)\n\nThis
reverts commit 86d2f58.\r\n\r\nForward
port of #172943 targeting\r\n8.13
and 8.12. See the linked pr for 8.11.3 release notes.\r\n\r\nCloses
#172919}]
BACKPORT-->

Co-authored-by: Jon <jon@elastic.co>
Co-authored-by: Brad White <Ikuni17@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delanni delanni delanni approved these changes

Assignees
No one assigned
Labels
release_note:fix Team:Operations Team label for Operations Team v8.11.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbudz @elasticmachine @kibana-ci @delanni