Splits repository api unit tests into individual tests #173218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
chore
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
|
@elasticmachine merge upstream |
|
FYI @elastic/kibana-security |
pgayvallet
approved these changes
Dec 13, 2023
Comment on lines
54
to
55
| // BEWARE: The SavedObjectClient depends on the implementation details of the SavedObjectsRepository | ||
| // so any breaking changes to this repository are considered breaking changes to the SavedObjectsClient. |
There was a problem hiding this comment.
NIT: no really sure why that comment was on the SOR test file in the first place, seems like something that was very old. I think we should remove it from all those files now.
There was a problem hiding this comment.
Done: 8276f13
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Structural cleanup of the
SavedObjectsRepository, continued from where #157154 left off.This PR holds changes to
repository.test.ts, and splits the api unit tests into dedicated test files next to the api implementation.Tests
This PR does not alter test coverage, its primary aim is to improve DevEx when it comes to SOR api unit testing. Hopefully, it'll make life easier for everyone touching the code.