[ML] Enhances toast notifications to improve error reporting #173362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
release_note:enhancement
review
:ml
backport:skip
|
Pinging @elastic/ml-ui (:ml) |
darnautov
reviewed
Dec 18, 2023
| const { toasts } = notifications; | ||
| toasts.addDanger( | ||
| const toastNotificationService = toastNotificationServiceProvider(toasts); |
There was a problem hiding this comment.
Suggested change
| const toastNotificationService = toastNotificationServiceProvider(toasts); | |
| const toastNotificationService = useToastNotificationService(); |
There was a problem hiding this comment.
Done in 39a1915
| @@ -30,6 +30,7 @@ import { parseUrlState } from '@kbn/ml-url-state'; | |||
|
|
|||
| import { useMlKibana } from '../../../contexts/kibana'; | |||
| import { isValidLabel, openCustomUrlWindow } from '../../../util/custom_url_utils'; | |||
| import { toastNotificationServiceProvider } from '../../../services/toast_notification_service'; | |||
There was a problem hiding this comment.
Suggested change
| import { toastNotificationServiceProvider } from '../../../services/toast_notification_service'; |
There was a problem hiding this comment.
Done in 39a1915
x-pack/plugins/ml/public/application/components/custom_urls/custom_urls.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/components/rule_editor/rule_editor_flyout.js
Outdated
Show resolved
Hide resolved
peteharverson
force-pushed
the
ml-toasts-enhancements
branch
from
0ff0ced
to
39a1915
Compare
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Several enhancements to the error toast notifications in the ML plugin to improve error reporting.
The bulk of the changes are to add 'See the full error' buttons to the toasts allowing the user to see further details on the error that has occurred. Also makes minor edits to some of the error messages to improve clarity.
Also closes #171839 by changes to
x-pack/plugins/ml/public/application/jobs/jobs_list/components/utils.jsso that the the 'Jobs started successfully' toast is only shown if 1 or more jobs have been started successfully.Fixes #171839
Checklist