[APM] Add filter to /has_data api
#173382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
sorenlouv
force-pushed
the
add-time-range-to-has-data-api
branch
from
ae364f5
to
3cf90c4
Compare
cauemarcondes
approved these changes
Dec 14, 2023
x-pack/plugins/apm/server/routes/historical_data/has_historical_agent_data.ts
Show resolved
Hide resolved
sorenlouv
force-pushed
the
add-time-range-to-has-data-api
branch
2 times, most recently
from
5000f50
to
222099d
Compare
sorenlouv
changed the title
/has_data api/has_data api
sorenlouv
force-pushed
the
add-time-range-to-has-data-api
branch
from
222099d
to
8678a39
Compare
Closes elastic#154997 Remove console.log Fix Use data_tier instead of timestamp Improve naming Undo change
sorenlouv
force-pushed
the
add-time-range-to-has-data-api
branch
from
0fd48bf
to
437b17f
Compare
dgieselaar
reviewed
Dec 18, 2023
x-pack/plugins/apm/server/routes/historical_data/has_historical_agent_data.ts
Outdated
Show resolved
Hide resolved
|
@sqren Can you please also backport this PR to 8.10 Though we will have to ask the customer who is on 8.8 to upgrade. Still |
No new releases are planned for 8.10.x afaict |
Ah true, then 8.12 atleast |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 18, 2023
Closes elastic#154997 This PR adds a data tier filter to the `/has_data` api, thus limitting the number of shards being hit by the request. (cherry picked from commit e7593c0)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 18, 2023
# Backport This will backport the following commits from `main` to `8.12`: - [[APM] Add filter to `/has_data` api (#173382)](#173382) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Søren Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2023-12-18T18:18:03Z","message":"[APM] Add filter to `/has_data` api (#173382)\n\nCloses #154997 PR adds a data tier filter to the `/has_data` api, thus limitting\r\nthe number of shards being hit by the request.","sha":"e7593c0e46f1ce707c1b951f8d013e722ac79353","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v8.12.0","v8.10.5","Team:obs-ux-infra_services","v8.13.0","v8.11.4"],"number":173382,"url":"#173382 Add filter to `/has_data` api (#173382)\n\nCloses #154997 PR adds a data tier filter to the `/has_data` api, thus limitting\r\nthe number of shards being hit by the request.","sha":"e7593c0e46f1ce707c1b951f8d013e722ac79353"}},"sourceBranch":"main","suggestedTargetBranches":["8.12","8.10","8.11"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.10","label":"v8.10.5","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"#173382 Add filter to `/has_data` api (#173382)\n\nCloses #154997 PR adds a data tier filter to the `/has_data` api, thus limitting\r\nthe number of shards being hit by the request.","sha":"e7593c0e46f1ce707c1b951f8d013e722ac79353"}},{"branch":"8.11","label":"v8.11.4","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #154997
This PR adds a data tier filter to the
/has_dataapi, thus limitting the number of shards being hit by the request.