Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified Search] Add GTE, LT options to filter options for date ranges and numbers #174283

Merged
merged 3 commits into from
Jan 12, 2024
Merged

[Unified Search] Add GTE, LT options to filter options for date ranges and numbers #174283

merged 3 commits into from
Jan 12, 2024

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Jan 4, 2024 •
edited
Loading

Summary

Fixes #158878

Adds two options for the unified search filters

greater or equal and less than

Screenshot 2024-01-12 at 10 43 14 Screenshot 2024-01-12 at 10 43 31

Changes labels for between filter pills.

For empty values:

Before:
Screenshot 2024-01-09 at 16 03 47

After:
Screenshot 2024-01-09 at 15 58 37

For only one boundary:

Before:
Screenshot 2024-01-09 at 16 03 34

After:
Screenshot 2024-01-09 at 16 02 09

A few comments:

  1. if you negate any of the new filters (gte, lt) it becomes a "not between" filter.
  2. If you only fill one boundary in the between filter it converts to greater or equal or less than filter

@mbondyra mbondyra added release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Unified search Unified search related tasks v8.13.0 labels Jan 4, 2024
@mbondyra mbondyra force-pushed the unified_search/add_gtltfilters branch 6 times, most recently from ad54aea to 23debd8 Compare January 9, 2024 13:37
@mbondyra mbondyra changed the title [Unified Search] add greater than options wip [Unified Search] Add GTE, LT options to filter options for date ranges and numbers Jan 9, 2024
@mbondyra mbondyra force-pushed the unified_search/add_gtltfilters branch 3 times, most recently from 23cc09c to 733e36b Compare January 10, 2024 11:40
@mbondyra mbondyra force-pushed the unified_search/add_gtltfilters branch from 733e36b to 897f775 Compare January 10, 2024 11:53
@mbondyra
Copy link
Contributor Author

/ci

@mbondyra mbondyra marked this pull request as ready for review January 11, 2024 10:41
@mbondyra mbondyra requested review from a team as code owners January 11, 2024 10:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@dej611
Copy link
Contributor

dej611 commented Jan 11, 2024

Not strictly related to this PR, but I found a bit annoying to rewrite the value every time I try to change type.

unified_search_change

dej611
dej611 reviewed Jan 11, 2024
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with Safari with both number and dates and it works great 👍

@stratoula
Copy link
Contributor

@dej611 you are right and this is why we have it on our 8.13 list :D #156842

@mbondyra mbondyra removed the request for review from amyjtechwriter January 12, 2024 09:42
@mbondyra mbondyra force-pushed the unified_search/add_gtltfilters branch from ba4c209 to 088478d Compare January 12, 2024 12:42
@mbondyra mbondyra requested review from a team as code owners January 12, 2024 12:42
@mbondyra mbondyra force-pushed the unified_search/add_gtltfilters branch from 088478d to a2f1311 Compare January 12, 2024 13:24
@mbondyra mbondyra removed request for a team January 12, 2024 13:33
@elastic elastic deleted a comment from kibana-ci Jan 12, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedSearch 214.6KB 216.3KB +1.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 410.6KB 410.6KB -45.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mbondyra

@mbondyra mbondyra merged commit eb299b0 into elastic:main Jan 12, 2024
20 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 12, 2024
semd pushed a commit to semd/kibana that referenced this pull request Jan 12, 2024
@mbondyra @semd
[Unified Search] Add GTE, LT options to filter options for date range…
301c562 
…s and numbers (elastic#174283)

## Summary


Fixes elastic#158878

### Adds two options for the unified search filters
`greater or equal` and `less than`

<img width="897" alt="Screenshot 2024-01-12 at 10 43 14"
src="https://github.com/elastic/kibana/assets/4283304/bd8b502a-8f77-4207-8d48-e8d66851f065">

<img width="898" alt="Screenshot 2024-01-12 at 10 43 31"
src="https://github.com/elastic/kibana/assets/4283304/34a23c56-9334-4d43-8820-175028672760">

### Changes labels for `between` filter pills. 

#### For empty values:
Before:
<img width="637" alt="Screenshot 2024-01-09 at 16 03 47"
src="https://github.com/elastic/kibana/assets/4283304/acd3b6ee-4774-45df-ade9-ab36daa744e1">

After:
<img width="906" alt="Screenshot 2024-01-09 at 15 58 37"
src="https://github.com/elastic/kibana/assets/4283304/318679fe-0078-43a0-815a-7f6936efa884">

#### For only one boundary:
Before:
<img width="641" alt="Screenshot 2024-01-09 at 16 03 34"
src="https://github.com/elastic/kibana/assets/4283304/b8d52abf-2556-4485-9aea-1bf0725b2945">

After:
<img width="733" alt="Screenshot 2024-01-09 at 16 02 09"
src="https://github.com/elastic/kibana/assets/4283304/2fc1b83a-97b5-4717-a244-042a78471fb0">

A few comments:

1. if you negate any of the new filters (gte, lt) it becomes a "not
between" filter.
2. If you only fill one boundary in the `between` filter it converts to
`greater or equal` or `less than` filter
@mbondyra mbondyra deleted the unified_search/add_gtltfilters branch January 12, 2024 20:26
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@mbondyra @CoenWarmer
[Unified Search] Add GTE, LT options to filter options for date range…
921a1af 
…s and numbers (elastic#174283)

## Summary


Fixes elastic#158878

### Adds two options for the unified search filters
`greater or equal` and `less than`

<img width="897" alt="Screenshot 2024-01-12 at 10 43 14"
src="https://github.com/elastic/kibana/assets/4283304/bd8b502a-8f77-4207-8d48-e8d66851f065">

<img width="898" alt="Screenshot 2024-01-12 at 10 43 31"
src="https://github.com/elastic/kibana/assets/4283304/34a23c56-9334-4d43-8820-175028672760">

### Changes labels for `between` filter pills. 

#### For empty values:
Before:
<img width="637" alt="Screenshot 2024-01-09 at 16 03 47"
src="https://github.com/elastic/kibana/assets/4283304/acd3b6ee-4774-45df-ade9-ab36daa744e1">

After:
<img width="906" alt="Screenshot 2024-01-09 at 15 58 37"
src="https://github.com/elastic/kibana/assets/4283304/318679fe-0078-43a0-815a-7f6936efa884">

#### For only one boundary:
Before:
<img width="641" alt="Screenshot 2024-01-09 at 16 03 34"
src="https://github.com/elastic/kibana/assets/4283304/b8d52abf-2556-4485-9aea-1bf0725b2945">

After:
<img width="733" alt="Screenshot 2024-01-09 at 16 02 09"
src="https://github.com/elastic/kibana/assets/4283304/2fc1b83a-97b5-4717-a244-042a78471fb0">

A few comments:

1. if you negate any of the new filters (gte, lt) it becomes a "not
between" filter.
2. If you only fill one boundary in the `between` filter it converts to
`greater or equal` or `less than` filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

Assignees

@mbondyra mbondyra

Labels
backport:skip This commit does not require backporting Feature:Unified search Unified search related tasks release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Unified Search] Add GTE, LT options to filter options for date ranges and numbers
6 participants
@mbondyra @elasticmachine @dej611 @stratoula @kibana-ci @kibanamachine