Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add flag for prerelease to templates/inputs endpoint #174471

Merged
merged 4 commits into from Jan 9, 2024

Conversation

criamico
Copy link
Contributor

@criamico criamico commented Jan 8, 2024

Fixes #172667

Summary

Some of the integrations show directly the prerelease version of the package in the overview section, but this wasn't happening in the "configs" section. Here I'm adding a flag to the templates/{pkgName}/{pkgVersion}/inputs endpoint that allows to select the prerelease tag as well:

  GET kbn:api/fleet/epm/templates/{pkgName}/{pkgVersion}/inputs?format=yaml&prerelease=true

One example is the Istio package:

  GET kbn:api/fleet/epm/templates/istio/0.5.0/inputs?format=yaml&prerelease=true

Istio overview - before

Screenshot 2024-01-08 at 17 45 16

Istio overview - after

Screenshot 2024-01-09 at 10 15 02

Checklist

@criamico criamico self-assigned this Jan 8, 2024
@criamico
Copy link
Contributor Author

criamico commented Jan 8, 2024

/ci

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@criamico criamico added the Team:Fleet Team label for Observability Data Collection Fleet team label Jan 9, 2024
@criamico criamico marked this pull request as ready for review January 9, 2024 11:13
@criamico criamico requested review from a team as code owners January 9, 2024 11:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 one small question about tests

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB +185.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (on behalf of docs)

@criamico criamico merged commit ccb3d39 into elastic:main Jan 9, 2024
21 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 9, 2024
@criamico criamico deleted the 172667_prerelease_for_inputs branch January 9, 2024 14:30
nreese pushed a commit to nreese/kibana that referenced this pull request Jan 10, 2024
…#174471)

Fixes elastic#172667

## Summary
Some of the integrations show directly the prerelease version of the
package in the overview section, but this wasn't happening in the
"configs" section. Here I'm adding a flag to the
`templates/{pkgName}/{pkgVersion}/inputs` endpoint that allows to select
the prerelease tag as well:
```
  GET kbn:api/fleet/epm/templates/{pkgName}/{pkgVersion}/inputs?format=yaml&prerelease=true
```
One example is the Istio package:
```
  GET kbn:api/fleet/epm/templates/istio/0.5.0/inputs?format=yaml&prerelease=true
```

### Istio overview - before

![Screenshot 2024-01-08 at 17 45
16](https://github.com/elastic/kibana/assets/16084106/bd48faac-5499-4de5-87f0-8addf5ec9961)

### Istio overview - after
![Screenshot 2024-01-09 at 10 15
02](https://github.com/elastic/kibana/assets/16084106/1aac5cfa-911a-498e-bc9b-4422e3c11c02)


### Checklist
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
delanni pushed a commit to delanni/kibana that referenced this pull request Jan 11, 2024
…#174471)

Fixes elastic#172667

## Summary
Some of the integrations show directly the prerelease version of the
package in the overview section, but this wasn't happening in the
"configs" section. Here I'm adding a flag to the
`templates/{pkgName}/{pkgVersion}/inputs` endpoint that allows to select
the prerelease tag as well:
```
  GET kbn:api/fleet/epm/templates/{pkgName}/{pkgVersion}/inputs?format=yaml&prerelease=true
```
One example is the Istio package:
```
  GET kbn:api/fleet/epm/templates/istio/0.5.0/inputs?format=yaml&prerelease=true
```

### Istio overview - before

![Screenshot 2024-01-08 at 17 45
16](https://github.com/elastic/kibana/assets/16084106/bd48faac-5499-4de5-87f0-8addf5ec9961)

### Istio overview - after
![Screenshot 2024-01-09 at 10 15
02](https://github.com/elastic/kibana/assets/16084106/1aac5cfa-911a-498e-bc9b-4422e3c11c02)


### Checklist
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
…#174471)

Fixes elastic#172667

## Summary
Some of the integrations show directly the prerelease version of the
package in the overview section, but this wasn't happening in the
"configs" section. Here I'm adding a flag to the
`templates/{pkgName}/{pkgVersion}/inputs` endpoint that allows to select
the prerelease tag as well:
```
  GET kbn:api/fleet/epm/templates/{pkgName}/{pkgVersion}/inputs?format=yaml&prerelease=true
```
One example is the Istio package:
```
  GET kbn:api/fleet/epm/templates/istio/0.5.0/inputs?format=yaml&prerelease=true
```

### Istio overview - before

![Screenshot 2024-01-08 at 17 45
16](https://github.com/elastic/kibana/assets/16084106/bd48faac-5499-4de5-87f0-8addf5ec9961)

### Istio overview - after
![Screenshot 2024-01-09 at 10 15
02](https://github.com/elastic/kibana/assets/16084106/1aac5cfa-911a-498e-bc9b-4422e3c11c02)


### Checklist
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Sample configs in Integrations UI are broken for prerelease packages
7 participants