New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Add flag for prerelease to templates/inputs endpoint #174471
Conversation
/ci |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/fleet (Team:Fleet) |
x-pack/test/fleet_api_integration/apis/epm/get_templates_inputs.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 one small question about tests
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @criamico |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (on behalf of docs)
…#174471) Fixes elastic#172667 ## Summary Some of the integrations show directly the prerelease version of the package in the overview section, but this wasn't happening in the "configs" section. Here I'm adding a flag to the `templates/{pkgName}/{pkgVersion}/inputs` endpoint that allows to select the prerelease tag as well: ``` GET kbn:api/fleet/epm/templates/{pkgName}/{pkgVersion}/inputs?format=yaml&prerelease=true ``` One example is the Istio package: ``` GET kbn:api/fleet/epm/templates/istio/0.5.0/inputs?format=yaml&prerelease=true ``` ### Istio overview - before ![Screenshot 2024-01-08 at 17 45 16](https://github.com/elastic/kibana/assets/16084106/bd48faac-5499-4de5-87f0-8addf5ec9961) ### Istio overview - after ![Screenshot 2024-01-09 at 10 15 02](https://github.com/elastic/kibana/assets/16084106/1aac5cfa-911a-498e-bc9b-4422e3c11c02) ### Checklist - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
…#174471) Fixes elastic#172667 ## Summary Some of the integrations show directly the prerelease version of the package in the overview section, but this wasn't happening in the "configs" section. Here I'm adding a flag to the `templates/{pkgName}/{pkgVersion}/inputs` endpoint that allows to select the prerelease tag as well: ``` GET kbn:api/fleet/epm/templates/{pkgName}/{pkgVersion}/inputs?format=yaml&prerelease=true ``` One example is the Istio package: ``` GET kbn:api/fleet/epm/templates/istio/0.5.0/inputs?format=yaml&prerelease=true ``` ### Istio overview - before ![Screenshot 2024-01-08 at 17 45 16](https://github.com/elastic/kibana/assets/16084106/bd48faac-5499-4de5-87f0-8addf5ec9961) ### Istio overview - after ![Screenshot 2024-01-09 at 10 15 02](https://github.com/elastic/kibana/assets/16084106/1aac5cfa-911a-498e-bc9b-4422e3c11c02) ### Checklist - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
…#174471) Fixes elastic#172667 ## Summary Some of the integrations show directly the prerelease version of the package in the overview section, but this wasn't happening in the "configs" section. Here I'm adding a flag to the `templates/{pkgName}/{pkgVersion}/inputs` endpoint that allows to select the prerelease tag as well: ``` GET kbn:api/fleet/epm/templates/{pkgName}/{pkgVersion}/inputs?format=yaml&prerelease=true ``` One example is the Istio package: ``` GET kbn:api/fleet/epm/templates/istio/0.5.0/inputs?format=yaml&prerelease=true ``` ### Istio overview - before ![Screenshot 2024-01-08 at 17 45 16](https://github.com/elastic/kibana/assets/16084106/bd48faac-5499-4de5-87f0-8addf5ec9961) ### Istio overview - after ![Screenshot 2024-01-09 at 10 15 02](https://github.com/elastic/kibana/assets/16084106/1aac5cfa-911a-498e-bc9b-4422e3c11c02) ### Checklist - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Fixes #172667
Summary
Some of the integrations show directly the prerelease version of the package in the overview section, but this wasn't happening in the "configs" section. Here I'm adding a flag to the
templates/{pkgName}/{pkgVersion}/inputs
endpoint that allows to select the prerelease tag as well:One example is the Istio package:
Istio overview - before
Istio overview - after
Checklist