Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Remove is_nan, is_finite, is_infinite functions #174674

Merged
merged 3 commits into from Jan 12, 2024

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Jan 11, 2024

Summary

Due to elastic/elasticsearch#104091 we have to remove them.

Screenshot 2024-01-11 at 11 24 50

Checklist

@dej611 dej611 added release_note:breaking Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:ES|QL v8.13.0 labels Jan 11, 2024
@dej611
Copy link
Contributor Author

dej611 commented Jan 11, 2024

/ci

@dej611 dej611 marked this pull request as ready for review January 11, 2024 16:28
@dej611 dej611 requested a review from a team as a code owner January 11, 2024 16:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@dej611 dej611 requested a review from a team as a code owner January 12, 2024 09:00
@dej611
Copy link
Contributor Author

dej611 commented Jan 12, 2024

@stratoula I forgot to remove them from doc, so I took the chance to remove them completely from Kibana with latest commit.

@dej611
Copy link
Contributor Author

dej611 commented Jan 12, 2024

/ci

@dej611
Copy link
Contributor Author

dej611 commented Jan 12, 2024

/ci

@stratoula
Copy link
Contributor

Thanx Marco, good call. The obs team updates the docs for the assistant with a script but I think it is fine if we remove them manually :D

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
textBasedLanguages 148.9KB 147.2KB -1.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 2.3MB 2.3MB -894.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 merged commit 5a32eb0 into elastic:main Jan 12, 2024
26 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 12, 2024
semd pushed a commit to semd/kibana that referenced this pull request Jan 12, 2024
## Summary

Due to elastic/elasticsearch#104091 we have to
remove them.

<img width="480" alt="Screenshot 2024-01-11 at 11 24 50"
src="https://github.com/elastic/kibana/assets/924948/c3495554-1a7d-4ae7-9a42-0d9ff785abc5">


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
## Summary

Due to elastic/elasticsearch#104091 we have to
remove them.

<img width="480" alt="Screenshot 2024-01-11 at 11 24 50"
src="https://github.com/elastic/kibana/assets/924948/c3495554-1a7d-4ae7-9a42-0d9ff785abc5">


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ES|QL release_note:breaking Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants