[APM] Synthtrace high cardinality scenarios #174746

sorenlouv · 2024-01-12T12:03:21Z

While working on #127036 I needed scenarios for creating a high number of services, transactions and errors. I've removed some unnecessary stuff in the scenarios that we already have elsewhere to make them run faster.

elasticmachine · 2024-01-12T12:03:28Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

apmmachine · 2024-01-12T12:03:38Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
/oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

kpatticha · 2024-01-12T13:04:59Z

packages/kbn-apm-synthtrace/src/scenarios/helpers/random_names.ts

+ * Side Public License, v 1.
+ */
+
+export const randomNames = [


this should be renamed to ancient Greek random names 😆

I thought you and @gbamparop would like it :D

kpatticha · 2024-01-12T13:09:47Z

packages/kbn-apm-synthtrace/src/scenarios/many_instances.ts

+    generate: ({ range, clients: { apmEsClient } }) => {
+      const instances = times(numInstances).map((index) => {
+        const agentVersion = agentVersions[index % agentVersions.length];
+        const randomName = serviceNames[index % serviceNames.length];


nit:

Suggested change

const randomName = serviceNames[index % serviceNames.length];

const randomName = getRandomNameForIndex[index];

kpatticha · 2024-01-12T13:10:24Z

packages/kbn-apm-synthtrace/src/scenarios/many_services.ts

            apm
              .service({
-                name: `${services[index % services.length]}-${language}-${index}`,
+                name: `${serviceNames[index % serviceNames.length]}-${language}-${index}`,


Suggested change

name: `${serviceNames[index % serviceNames.length]}-${language}-${index}`,

name: `${getRandomNameForIndex[index]-${language}-${index}`,

kibana-ci · 2024-01-12T14:56:56Z

💚 Build Succeeded

Buildkite Build
Commit: a6b9413

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2024-01-12T15:00:55Z

💔 All backports failed

Status	Branch	Result
❌	8.12	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 174746

Questions ?

Please refer to the Backport tool documentation

While working on elastic#127036 I needed scenarios for creating a high number of services, transactions and errors. I've removed some unnecessary stuff in the scenarios that we already have elsewhere to make them run faster.

achyutjhunjhunwala · 2024-01-13T22:04:36Z

packages/kbn-apm-synthtrace/src/scenarios/helpers/random_names.ts

+ * Side Public License, v 1.
+ */
+
+export const randomGreekishNames = [


@sqren If i were you, i would have sneaked in my name 😆

Closes: #127036 This adds the ability to easily search for data in tables. The search will be performed server side if there are more results than initially returned by Elasticsearch. If all results were returned the search is performed client side to provide a more snappy experience. The feature is guarded by a feature flag (disabled by default) and only available for services, transactions and errors table. # Transactions ![quick-filtering](https://github.com/elastic/kibana/assets/209966/20684b88-a103-4000-a012-ee6e35479b44) # Errors ![error3](https://github.com/elastic/kibana/assets/209966/c7f09dd9-24a5-482a-ae72-4c4477f65d3a) **Dependencies:** - #173973 - #174746 - #174750 --------- Co-authored-by: Caue Marcondes <caue.marcondes@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

…174490) Closes: elastic#127036 This adds the ability to easily search for data in tables. The search will be performed server side if there are more results than initially returned by Elasticsearch. If all results were returned the search is performed client side to provide a more snappy experience. The feature is guarded by a feature flag (disabled by default) and only available for services, transactions and errors table. # Transactions ![quick-filtering](https://github.com/elastic/kibana/assets/209966/20684b88-a103-4000-a012-ee6e35479b44) # Errors ![error3](https://github.com/elastic/kibana/assets/209966/c7f09dd9-24a5-482a-ae72-4c4477f65d3a) **Dependencies:** - elastic#173973 - elastic#174746 - elastic#174750 --------- Co-authored-by: Caue Marcondes <caue.marcondes@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

While working on elastic#127036 I needed scenarios for creating a high number of services, transactions and errors. I've removed some unnecessary stuff in the scenarios that we already have elsewhere to make them run faster.

…174490) Closes: elastic#127036 This adds the ability to easily search for data in tables. The search will be performed server side if there are more results than initially returned by Elasticsearch. If all results were returned the search is performed client side to provide a more snappy experience. The feature is guarded by a feature flag (disabled by default) and only available for services, transactions and errors table. # Transactions ![quick-filtering](https://github.com/elastic/kibana/assets/209966/20684b88-a103-4000-a012-ee6e35479b44) # Errors ![error3](https://github.com/elastic/kibana/assets/209966/c7f09dd9-24a5-482a-ae72-4c4477f65d3a) **Dependencies:** - elastic#173973 - elastic#174746 - elastic#174750 --------- Co-authored-by: Caue Marcondes <caue.marcondes@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

sorenlouv requested review from a team as code owners January 12, 2024 12:03

botelastic bot added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Jan 12, 2024

sorenlouv added release_note:skip Skip the PR/issue when compiling release notes and removed Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Jan 12, 2024

sorenlouv added the v8.12.0 label Jan 12, 2024

[APM] Synthtrace improvements

bbecbdf

sorenlouv force-pushed the synthtrace-improvements branch from e6ab8e1 to bbecbdf Compare January 12, 2024 12:04

botelastic bot added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Jan 12, 2024

sorenlouv removed the request for review from a team January 12, 2024 12:04

elastic deleted a comment from elasticmachine Jan 12, 2024

sorenlouv changed the title ~~[APM] Synthtrace improvements~~ [APM] Synthtrace high cardinality scenarios Jan 12, 2024

gbamparop approved these changes Jan 12, 2024

View reviewed changes

kpatticha reviewed Jan 12, 2024

View reviewed changes

kpatticha approved these changes Jan 12, 2024

View reviewed changes

sorenlouv mentioned this pull request Jan 12, 2024

[APM] Add table search to services, transactions and errors #174490

Merged

Address feedback

a6b9413

sorenlouv enabled auto-merge (squash) January 12, 2024 13:45

sorenlouv merged commit 6eb91e8 into elastic:main Jan 12, 2024
20 of 21 checks passed

kibanamachine added the v8.13.0 label Jan 12, 2024

sorenlouv deleted the synthtrace-improvements branch January 12, 2024 15:44

sorenlouv removed the v8.12.0 label Jan 12, 2024

kibanamachine added the backport:skip This commit does not require backporting label Jan 12, 2024

achyutjhunjhunwala reviewed Jan 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APM] Synthtrace high cardinality scenarios #174746

[APM] Synthtrace high cardinality scenarios #174746

sorenlouv commented Jan 12, 2024 •

edited by kibanamachine

Loading

elasticmachine commented Jan 12, 2024

apmmachine commented Jan 12, 2024

kpatticha Jan 12, 2024

sorenlouv Jan 12, 2024

kpatticha Jan 12, 2024

kpatticha Jan 12, 2024

kibana-ci commented Jan 12, 2024

kibanamachine commented Jan 12, 2024

achyutjhunjhunwala Jan 13, 2024 •

edited

Loading

	const randomName = serviceNames[index % serviceNames.length];
	const randomName = getRandomNameForIndex[index];

	name: `${serviceNames[index % serviceNames.length]}-${language}-${index}`,
	name: `${getRandomNameForIndex[index]-${language}-${index}`,

[APM] Synthtrace high cardinality scenarios #174746

[APM] Synthtrace high cardinality scenarios #174746

Conversation

sorenlouv commented Jan 12, 2024 • edited by kibanamachine Loading

elasticmachine commented Jan 12, 2024

apmmachine commented Jan 12, 2024

🤖 GitHub comments

kpatticha Jan 12, 2024

Choose a reason for hiding this comment

sorenlouv Jan 12, 2024

Choose a reason for hiding this comment

kpatticha Jan 12, 2024

Choose a reason for hiding this comment

kpatticha Jan 12, 2024

Choose a reason for hiding this comment

kibana-ci commented Jan 12, 2024

💚 Build Succeeded

Metrics [docs]

kibanamachine commented Jan 12, 2024

💔 All backports failed

Manual backport

Questions ?

achyutjhunjhunwala Jan 13, 2024 • edited Loading

Choose a reason for hiding this comment

sorenlouv commented Jan 12, 2024 •

edited by kibanamachine

Loading

achyutjhunjhunwala Jan 13, 2024 •

edited

Loading