Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAM] Stack management rules available with only ml feature #174791

Merged
merged 2 commits into from Jan 16, 2024

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Jan 12, 2024

Summary

Fix => #173573

@XavierM XavierM added release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team:ML Team label for ML (also use :ml) v8.12.1 v8.13.0 labels Jan 12, 2024
@XavierM XavierM requested a review from a team as a code owner January 12, 2024 18:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@XavierM XavierM changed the title [RAM] Stack management rules available with only ml plugin [RAM] Stack management rules available with only ml feature Jan 12, 2024
@darnautov
Copy link
Contributor

Tested and LGTM.

  • The user with full ML access is able to view alerting rules in the Rules UI even when Kibana privilege isn't enabled.
  • The user with read ML access does not have access to the Rules UI

@XavierM XavierM enabled auto-merge (squash) January 16, 2024 15:03
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 78.1KB 78.2KB +35.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 5d5f0d1 into elastic:main Jan 16, 2024
19 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 16, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 16, 2024
…174791) (#174940)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[RAM] Stack management rules available with only ml feature
(#174791)](#174791)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Xavier
Mouligneau","email":"xavier.mouligneau@elastic.co"},"sourceCommit":{"committedDate":"2024-01-16T16:13:02Z","message":"[RAM]
Stack management rules available with only ml feature (#174791)\n\n##
Summary\r\n\r\nFix =>
#173573
Stack management rules available with only ml
feature","number":174791,"url":"#174791
Stack management rules available with only ml feature (#174791)\n\n##
Summary\r\n\r\nFix =>
#173573
Stack management rules available with only ml feature (#174791)\n\n##
Summary\r\n\r\nFix =>
#173573"}}]}]
BACKPORT-->

Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Jan 17, 2024
@mistic mistic removed the v8.12.0 label Jan 17, 2024
@mistic
Copy link
Member

mistic commented Jan 17, 2024

This PR didn't make it into the latest BC for 8.12.0. Updating the labels.

CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:fix Team:ML Team label for ML (also use :ml) Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.1 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants