Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][FE] Alert creation delay based on user definition #175153

Closed

Conversation

doakalexi
Copy link
Contributor

@doakalexi doakalexi commented Jan 18, 2024

Resolves #173009

Summary

Adds a new input for the user to define the notificationDelay. This input is available for life-cycled alerts (stack and o11y) rule types.

Checklist

Delete any items that are not applicable to this PR.

To verify

  • Using the UI create a rule with the notificationDelay field set.
  • Verify that the field is saved properly and that you can edit the notificationDelay
  • Verify that you can add the notification delay to existing rules. Create a rule in a different branch and switch to this one. Edit the rule and set the notificationDelay. Verify that the rule saves and works as expected.

@doakalexi
Copy link
Contributor Author

/ci

@doakalexi
Copy link
Contributor Author

/ci

@doakalexi doakalexi changed the title Alerting/notification delay fe [ResponseOps][FE] Alert creation delay based on user definition Jan 23, 2024
@doakalexi
Copy link
Contributor Author

/ci

@doakalexi doakalexi marked this pull request as ready for review January 23, 2024 21:16
@doakalexi doakalexi requested a review from a team as a code owner January 23, 2024 21:16
@doakalexi
Copy link
Contributor Author

doakalexi commented Jan 23, 2024

@lcawl and @mdefazio could you take a look at the ui and copy changes when you have a chance pls
I think the label and help text in the tooltip could be better.

@doakalexi doakalexi added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Jan 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.4MB 1.4MB +1.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 106.2KB 106.3KB +51.0B
Unknown metric groups

References to deprecated APIs

id before after diff
triggersActionsUi 50 51 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@doakalexi doakalexi requested a review from a team as a code owner January 29, 2024 23:08
@doakalexi doakalexi closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:enhancement Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert creation delay based on user definition
3 participants