Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] ESQL geo_shape support #175156

Merged
merged 9 commits into from Jan 22, 2024
Merged

[Maps] ESQL geo_shape support #175156

merged 9 commits into from Jan 22, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 18, 2024 •
edited

elastic/elasticsearch#104269 adds geo_shape support to ESQL

This PR updates maps ESQL source to support geo_shape column type
Screenshot 2024-01-18 at 1 15 31 PM

@nreese nreese requested a review from a team as a code owner January 18, 2024 20:18
@nreese nreese added release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Maps v8.13.0 labels Jan 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Contributor Author

nreese commented Jan 22, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.9MB 2.9MB +224.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nickpeihl
nickpeihl approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! code review and tested both geo_point and geo_shape fields with ES|QL. I also created an index with multiple geo_* fields and they all work well together.

@nreese nreese merged commit f6caec7 into elastic:main Jan 22, 2024
16 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 22, 2024
lcawl pushed a commit to lcawl/kibana that referenced this pull request Jan 26, 2024
@nreese @kibanamachine @lcawl
[Maps] ESQL geo_shape support (elastic#175156)
f37c576 
elastic/elasticsearch#104269 adds geo_shape
support to ESQL

This PR updates maps ESQL source to support geo_shape column type
<img width="800" alt="Screenshot 2024-01-18 at 1 15 31 PM"
src="https://github.com/elastic/kibana/assets/373691/844251a6-4409-45f4-89f5-513f4537d833">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@ThomThomson ThomThomson added loe:medium Medium Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Feb 8, 2024
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@nreese @kibanamachine @CoenWarmer
[Maps] ESQL geo_shape support (elastic#175156)
55bec2e 
elastic/elasticsearch#104269 adds geo_shape
support to ESQL

This PR updates maps ESQL source to support geo_shape column type
<img width="800" alt="Screenshot 2024-01-18 at 1 15 31 PM"
src="https://github.com/elastic/kibana/assets/373691/844251a6-4409-45f4-89f5-513f4537d833">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@nreese @kibanamachine @CoenWarmer
[Maps] ESQL geo_shape support (elastic#175156)
8dc22fb 
elastic/elasticsearch#104269 adds geo_shape
support to ESQL

This PR updates maps ESQL source to support geo_shape column type
<img width="800" alt="Screenshot 2024-01-18 at 1 15 31 PM"
src="https://github.com/elastic/kibana/assets/373691/844251a6-4409-45f4-89f5-513f4537d833">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees

@nreese nreese

Labels
backport:skip This commit does not require backporting Feature:Maps impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nreese @elasticmachine @kibana-ci @nickpeihl @ThomThomson @kibanamachine