Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLO] Enable timeslice metric visualization on SLO detail page #175281

Merged
merged 2 commits into from Jan 30, 2024
Merged

[SLO] Enable timeslice metric visualization on SLO detail page #175281

merged 2 commits into from Jan 30, 2024

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Jan 23, 2024 •
edited

Summary

This PR adds support for the Timeslice Metric visualization on the SLO Detail page.

Fixes #170135

image

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@simianhacker simianhacker marked this pull request as ready for review January 29, 2024 20:33
@simianhacker simianhacker requested a review from a team as a code owner January 29, 2024 20:33
@simianhacker simianhacker added release_note:feature Makes this part of the condensed release notes Team:obs-ux-management Observability Management User Experience Team v8.13.0 labels Jan 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@simianhacker simianhacker force-pushed the issue-170135-timeslice-metric-vis branch from 54d1dd0 to 3306d04 Compare January 29, 2024 20:35
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/slo-schema 144 146 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 630.6KB 632.8KB +2.2KB
Unknown metric groups

API count

id before after diff
@kbn/slo-schema 144 146 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kdelemme
kdelemme approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Very nice improvement on the preview chart as well ! And thanks for fixing the instanceId filter 👏🏻

@simianhacker simianhacker merged commit 134b25c into elastic:main Jan 30, 2024
18 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 30, 2024
nreese pushed a commit to nreese/kibana that referenced this pull request Jan 31, 2024
@simianhacker @nreese
[SLO] Enable timeslice metric visualization on SLO detail page (elast…
d6c3e92 
…ic#175281)

## Summary

This PR adds support for the Timeslice Metric visualization on the SLO
Detail page.

Fixes elastic#170135 

<img width="1756" alt="image"
src="https://github.com/elastic/kibana/assets/41702/56599b91-8827-4c6a-9df1-ccd80c5ab097">
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Feb 5, 2024
@simianhacker @WafaaNasr
[SLO] Enable timeslice metric visualization on SLO detail page (elast…
e9782f0 
…ic#175281)

## Summary

This PR adds support for the Timeslice Metric visualization on the SLO
Detail page.

Fixes elastic#170135 

<img width="1756" alt="image"
src="https://github.com/elastic/kibana/assets/41702/56599b91-8827-4c6a-9df1-ccd80c5ab097">
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Feb 6, 2024
@simianhacker @WafaaNasr
[SLO] Enable timeslice metric visualization on SLO detail page (elast…
99582a8 
…ic#175281)

## Summary

This PR adds support for the Timeslice Metric visualization on the SLO
Detail page.

Fixes elastic#170135 

<img width="1756" alt="image"
src="https://github.com/elastic/kibana/assets/41702/56599b91-8827-4c6a-9df1-ccd80c5ab097">
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@simianhacker @CoenWarmer
[SLO] Enable timeslice metric visualization on SLO detail page (elast…
b1d8d83 
…ic#175281)

## Summary

This PR adds support for the Timeslice Metric visualization on the SLO
Detail page.

Fixes elastic#170135 

<img width="1756" alt="image"
src="https://github.com/elastic/kibana/assets/41702/56599b91-8827-4c6a-9df1-ccd80c5ab097">
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@simianhacker @CoenWarmer
[SLO] Enable timeslice metric visualization on SLO detail page (elast…
0ecba9b 
…ic#175281)

## Summary

This PR adds support for the Timeslice Metric visualization on the SLO
Detail page.

Fixes elastic#170135 

<img width="1756" alt="image"
src="https://github.com/elastic/kibana/assets/41702/56599b91-8827-4c6a-9df1-ccd80c5ab097">
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@simianhacker @fkanout
[SLO] Enable timeslice metric visualization on SLO detail page (elast…
918f250 
…ic#175281)

## Summary

This PR adds support for the Timeslice Metric visualization on the SLO
Detail page.

Fixes elastic#170135 

<img width="1756" alt="image"
src="https://github.com/elastic/kibana/assets/41702/56599b91-8827-4c6a-9df1-ccd80c5ab097">
@simianhacker simianhacker deleted the issue-170135-timeslice-metric-vis branch April 17, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdelemme kdelemme kdelemme approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:obs-ux-management Observability Management User Experience Team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SLO] Add visualization for timeslice metric to SLO detail
6 participants
@simianhacker @apmmachine @elasticmachine @kibana-ci @kdelemme @kibanamachine