[Response Ops][Actions] Fixing bug where context variables are not passed in when alerts as data doc is available in action params #175682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
ymao1
changed the title
ymao1
added
bug
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @ymao1 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 26, 2024
…ssed in when alerts as data doc is available in action params (elastic#175682) Resolves elastic#175624 ## Summary Fixes a bug where context and state variables were not passed to the action params for interpolation if the alert-as-data document is available. ## To Verify * Create a rule and add an action that fires `For each alert - on check intervals` * Add a condition to the action, either a KQL query or a time range * Make sure the action message references some context variables (default ES query or Index Threshold rule messages should include context variables) * Save the rule and make sure the action fired correctly includes the referenced context variables. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 8a6ee8a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 27, 2024
… not passed in when alerts as data doc is available in action params (#175682) (#175737) # Backport This will backport the following commits from `main` to `8.12`: - [[Response Ops][Actions] Fixing bug where context variables are not passed in when alerts as data doc is available in action params (#175682)](#175682) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ying Mao","email":"ying.mao@elastic.co"},"sourceCommit":{"committedDate":"2024-01-26T21:36:35Z","message":"[Response Ops][Actions] Fixing bug where context variables are not passed in when alerts as data doc is available in action params (#175682)\n\nResolves #175624 Summary\r\n\r\nFixes a bug where context and state variables were not passed to the\r\naction params for interpolation if the alert-as-data document is\r\navailable.\r\n\r\n## To Verify\r\n* Create a rule and add an action that fires `For each alert - on check\r\nintervals`\r\n* Add a condition to the action, either a KQL query or a time range\r\n* Make sure the action message references some context variables\r\n(default ES query or Index Threshold rule messages should include\r\ncontext variables)\r\n* Save the rule and make sure the action fired correctly includes the\r\nreferenced context variables.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"8a6ee8a4c0df7f687c57748c1e9f1155167b00aa","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Feature:Actions","Team:ResponseOps","v8.12.1","v8.13.0"],"title":"[Response Ops][Actions] Fixing bug where context variables are not passed in when alerts as data doc is available in action params","number":175682,"url":"#175682 Ops][Actions] Fixing bug where context variables are not passed in when alerts as data doc is available in action params (#175682)\n\nResolves #175624 Summary\r\n\r\nFixes a bug where context and state variables were not passed to the\r\naction params for interpolation if the alert-as-data document is\r\navailable.\r\n\r\n## To Verify\r\n* Create a rule and add an action that fires `For each alert - on check\r\nintervals`\r\n* Add a condition to the action, either a KQL query or a time range\r\n* Make sure the action message references some context variables\r\n(default ES query or Index Threshold rule messages should include\r\ncontext variables)\r\n* Save the rule and make sure the action fired correctly includes the\r\nreferenced context variables.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"8a6ee8a4c0df7f687c57748c1e9f1155167b00aa"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"#175682 Ops][Actions] Fixing bug where context variables are not passed in when alerts as data doc is available in action params (#175682)\n\nResolves #175624 Summary\r\n\r\nFixes a bug where context and state variables were not passed to the\r\naction params for interpolation if the alert-as-data document is\r\navailable.\r\n\r\n## To Verify\r\n* Create a rule and add an action that fires `For each alert - on check\r\nintervals`\r\n* Add a condition to the action, either a KQL query or a time range\r\n* Make sure the action message references some context variables\r\n(default ES query or Index Threshold rule messages should include\r\ncontext variables)\r\n* Save the rule and make sure the action fired correctly includes the\r\nreferenced context variables.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"8a6ee8a4c0df7f687c57748c1e9f1155167b00aa"}}]}] BACKPORT--> Co-authored-by: Ying Mao <ying.mao@elastic.co>
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…ssed in when alerts as data doc is available in action params (elastic#175682) Resolves elastic#175624 ## Summary Fixes a bug where context and state variables were not passed to the action params for interpolation if the alert-as-data document is available. ## To Verify * Create a rule and add an action that fires `For each alert - on check intervals` * Add a condition to the action, either a KQL query or a time range * Make sure the action message references some context variables (default ES query or Index Threshold rule messages should include context variables) * Save the rule and make sure the action fired correctly includes the referenced context variables. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…ssed in when alerts as data doc is available in action params (elastic#175682) Resolves elastic#175624 ## Summary Fixes a bug where context and state variables were not passed to the action params for interpolation if the alert-as-data document is available. ## To Verify * Create a rule and add an action that fires `For each alert - on check intervals` * Add a condition to the action, either a KQL query or a time range * Make sure the action message references some context variables (default ES query or Index Threshold rule messages should include context variables) * Save the rule and make sure the action fired correctly includes the referenced context variables. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #175624
Summary
Fixes a bug where context and state variables were not passed to the action params for interpolation if the alert-as-data document is available.
To Verify
For each alert - on check intervals