Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting/CSV] Insert error message into contents if export is empty #175852

Merged
merged 4 commits into from Jan 31, 2024
Merged

[Reporting/CSV] Insert error message into contents if export is empty #175852

merged 4 commits into from Jan 31, 2024

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Jan 29, 2024 •
edited

Summary

Closes #174659

Release note

Updated CSV export to insert error messages into the contents if the export results in an empty file due to an error.

Checklist

Delete any items that are not applicable to this PR.

@tsullivan tsullivan self-assigned this Jan 29, 2024
@tsullivan tsullivan added enhancement New value added to drive a business result Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Feature:Reporting Reporting (PDF, CSV, ..) feature labels Jan 29, 2024
@tsullivan tsullivan marked this pull request as ready for review January 29, 2024 23:56
@tsullivan tsullivan requested a review from a team as a code owner January 29, 2024 23:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tsullivan

rshen91
rshen91 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@rshen91 rshen91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YESSSSSSSSS

@tsullivan tsullivan merged commit 9f84b98 into elastic:main Jan 31, 2024
19 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Jan 31, 2024
@tsullivan tsullivan deleted the reporting/csv-insert-error-message-if-empty branch January 31, 2024 16:19
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Feb 5, 2024
@tsullivan @WafaaNasr
[Reporting/CSV] Insert error message into contents if export is empty (…
6f15969 
…elastic#175852)

## Summary

Closes elastic#174659

### Release note
Updated CSV export to insert error messages into the contents if the
export results in an empty file due to an error.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Feb 6, 2024
@tsullivan @WafaaNasr
[Reporting/CSV] Insert error message into contents if export is empty (…
022b03b 
…elastic#175852)

## Summary

Closes elastic#174659

### Release note
Updated CSV export to insert error messages into the contents if the
export results in an empty file due to an error.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@tsullivan @CoenWarmer
[Reporting/CSV] Insert error message into contents if export is empty (…
b3679b2 
…elastic#175852)

## Summary

Closes elastic#174659

### Release note
Updated CSV export to insert error messages into the contents if the
export results in an empty file due to an error.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@tsullivan @CoenWarmer
[Reporting/CSV] Insert error message into contents if export is empty (…
3064130 
…elastic#175852)

## Summary

Closes elastic#174659

### Release note
Updated CSV export to insert error messages into the contents if the
export results in an empty file due to an error.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@tsullivan @fkanout
[Reporting/CSV] Insert error message into contents if export is empty (…
a9bcec3 
…elastic#175852)

## Summary

Closes elastic#174659

### Release note
Updated CSV export to insert error messages into the contents if the
export results in an empty file due to an error.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rshen91 rshen91 rshen91 approved these changes

Assignees

@tsullivan tsullivan

Labels
backport:skip This commit does not require backporting enhancement New value added to drive a business result Feature:Reporting Reporting (PDF, CSV, ..) feature release_note:enhancement Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Reporting] avoid empty CSV exports by including any available warning or error messages
5 participants
@tsullivan @elasticmachine @kibana-ci @rshen91 @kibanamachine