Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] added output validation when creating package policy #175985

Merged
merged 3 commits into from Jan 31, 2024
Merged

[Fleet] added output validation when creating package policy #175985

merged 3 commits into from Jan 31, 2024

Conversation

juliaElastic
Copy link
Contributor

Summary

Closes #165816

Added validation to prevent adding an integration to an agent policy that uses an output different than elasticsearch.

To verify:

  1. Create a logstash output and make it default output by enabling the toggles.
  2. Navigate to Integrations and search Fleet Server integration.
  3. Add this fleet server integration to a new or existing policy.
  4. There should be an error popup saying that this integration can't be added to the agent policy.
image

Checklist

@juliaElastic juliaElastic self-assigned this Jan 31, 2024
@juliaElastic juliaElastic requested a review from a team as a code owner January 31, 2024 13:59
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jan 31, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

nchaulet
nchaulet approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM 🚀

@juliaElastic juliaElastic changed the title [Fleeet] added output validation when creating package policy [Fleet] added output validation when creating package policy Jan 31, 2024
@juliaElastic juliaElastic enabled auto-merge (squash) January 31, 2024 15:18
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 151.7KB 151.6KB -38.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

@juliaElastic juliaElastic merged commit e654a5b into elastic:main Jan 31, 2024
19 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Jan 31, 2024
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Feb 5, 2024
@juliaElastic @WafaaNasr
[Fleet] added output validation when creating package policy (elastic…
6eb88a8 
…#175985)

## Summary

Closes elastic#165816

Added validation to prevent adding an integration to an agent policy
that uses an output different than `elasticsearch`.

To verify:
1. Create a logstash output and make it default output by enabling the
toggles.
2. Navigate to Integrations and search Fleet Server integration.
3. Add this fleet server integration to a new or existing policy.
4. There should be an error popup saying that this integration can't be
added to the agent policy.

<img width="1439" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/13f39bfc-8af1-4fa7-95e8-7ff41c6439a4">


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Feb 6, 2024
@juliaElastic @WafaaNasr
[Fleet] added output validation when creating package policy (elastic…
cb0406b 
…#175985)

## Summary

Closes elastic#165816

Added validation to prevent adding an integration to an agent policy
that uses an output different than `elasticsearch`.

To verify:
1. Create a logstash output and make it default output by enabling the
toggles.
2. Navigate to Integrations and search Fleet Server integration.
3. Add this fleet server integration to a new or existing policy.
4. There should be an error popup saying that this integration can't be
added to the agent policy.

<img width="1439" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/13f39bfc-8af1-4fa7-95e8-7ff41c6439a4">


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@juliaElastic @CoenWarmer
[Fleet] added output validation when creating package policy (elastic…
f56a1a4 
…#175985)

## Summary

Closes elastic#165816

Added validation to prevent adding an integration to an agent policy
that uses an output different than `elasticsearch`.

To verify:
1. Create a logstash output and make it default output by enabling the
toggles.
2. Navigate to Integrations and search Fleet Server integration.
3. Add this fleet server integration to a new or existing policy.
4. There should be an error popup saying that this integration can't be
added to the agent policy.

<img width="1439" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/13f39bfc-8af1-4fa7-95e8-7ff41c6439a4">


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@juliaElastic @CoenWarmer
[Fleet] added output validation when creating package policy (elastic…
36254ac 
…#175985)

## Summary

Closes elastic#165816

Added validation to prevent adding an integration to an agent policy
that uses an output different than `elasticsearch`.

To verify:
1. Create a logstash output and make it default output by enabling the
toggles.
2. Navigate to Integrations and search Fleet Server integration.
3. Add this fleet server integration to a new or existing policy.
4. There should be an error popup saying that this integration can't be
added to the agent policy.

<img width="1439" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/13f39bfc-8af1-4fa7-95e8-7ff41c6439a4">


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@juliaElastic @fkanout
[Fleet] added output validation when creating package policy (elastic…
e59b139 
…#175985)

## Summary

Closes elastic#165816

Added validation to prevent adding an integration to an agent policy
that uses an output different than `elasticsearch`.

To verify:
1. Create a logstash output and make it default output by enabling the
toggles.
2. Navigate to Integrations and search Fleet Server integration.
3. Add this fleet server integration to a new or existing policy.
4. There should be an error popup saying that this integration can't be
added to the agent policy.

<img width="1439" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/13f39bfc-8af1-4fa7-95e8-7ff41c6439a4">


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@juliaElastic juliaElastic

Labels
backport:skip This commit does not require backporting release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet]: Fleet server integration gets added to the agent policy having (default)Logstash output selected.
6 participants
@juliaElastic @elasticmachine @apmmachine @kibana-ci @nchaulet @kibanamachine