Select color for hits #176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rather than have each control deal with this on it's own (See pull request 175 as well), some sort of "unified" color selection widget that can be attached to the other ones makes more sense, I think. Better to have the colorable widgets surface the needed hooks than to each implement it themselves. |
|
I'd rather see this implemented as a color picker than a drop down of defined colors. As @cdeszaq pointed out, this should be implemented as a color service that can assign colors to existing queries so they are sync'd across panels |
Closed
|
That was my choice, but I do not succeed to incorporate a color picker. So I put a drop-down until somebody does. |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 3, 2016
- Closes elastic#173 - Adding significant_terms to KB - Closes elastic#172 - Adding percentiles to KB - Closes elastic#171 - Adding cardinality agg to KB - Closes elastic#176 - Removing custom_score and custom_boost_factor from query for 1.0 - Closes elastic#178 - Add script support to value_count agg - Closes elastic#180 and Closes elastic#179 - Adding _cat/plugins and _cat/segments endpoints - Closes elastic#191
harper-carroll
pushed a commit
to harper-carroll/kibana
that referenced
this pull request
Jul 11, 2016
harper-carroll
pushed a commit
to harper-carroll/kibana
that referenced
this pull request
Jul 11, 2016
Merge pull request elastic#176 from Logrhythm/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.