Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Links] Set empty default title for Links saved to library #176021

Merged
merged 1 commit into from Feb 1, 2024

Conversation

nickpeihl
Copy link
Member

Fixes #176016

Summary

Fixes form validation when saving Links to library.

@nickpeihl nickpeihl requested a review from a team as a code owner January 31, 2024 21:45
@nickpeihl nickpeihl added release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Jan 31, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
links 25.1KB 25.1KB +34.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Tested locally in chrome

@nickpeihl nickpeihl merged commit 38872c6 into elastic:main Feb 1, 2024
25 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 1, 2024
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Feb 6, 2024
…76021)

Fixes elastic#176016 

## Summary

Fixes form validation when saving Links to library.
fkanout pushed a commit to fkanout/kibana that referenced this pull request Feb 7, 2024
…76021)

Fixes elastic#176016 

## Summary

Fixes form validation when saving Links to library.
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
…76021)

Fixes elastic#176016 

## Summary

Fixes form validation when saving Links to library.
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
…76021)

Fixes elastic#176016 

## Summary

Fixes form validation when saving Links to library.
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
…76021)

Fixes elastic#176016 

## Summary

Fixes form validation when saving Links to library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links panel save links panel to library ->save is missing name validation
5 participants