Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] AIOps: Adds UI action for Change Point Detection embeddable to open in the ML app #176694

Merged
merged 7 commits into from Feb 13, 2024
Merged

[ML] AIOps: Adds UI action for Change Point Detection embeddable to open in the ML app #176694

merged 7 commits into from Feb 13, 2024

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Feb 12, 2024 •
edited

Summary

Closes #161248

Added a UI action to open change point detection in the AIOps labs.

image

Checklist

@darnautov darnautov added release_note:enhancement :ml Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.13.0 labels Feb 12, 2024
@darnautov darnautov self-assigned this Feb 12, 2024
@darnautov darnautov marked this pull request as ready for review February 12, 2024 13:30
@darnautov darnautov requested review from a team as code owners February 12, 2024 13:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov mentioned this pull request Feb 12, 2024
Closed
peteharverson
peteharverson approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM. Just left a couple of minor comments.

x-pack/plugins/ml/public/locator/formatters/aiops.ts Outdated Show resolved Hide resolved
x-pack/plugins/aiops/public/ui_actions/open_change_point_ml.tsx Outdated Show resolved Hide resolved
jgowdyelastic
jgowdyelastic approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments, but on the whole LGTM

x-pack/plugins/aiops/public/ui_actions/index.ts Outdated Show resolved Hide resolved
darnautov and others added 2 commits February 13, 2024 13:46
@darnautov darnautov enabled auto-merge (squash) February 13, 2024 13:02
@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #36 / APM API tests correlations/field_value_pairs.spec.ts trial 8.0.0 "before all" hook: runBefore in "8.0.0"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 430 431 +1
ml 1919 1920 +1
total +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 398.9KB 399.7KB +840.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 78.5KB 79.0KB +547.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit 550c10d into elastic:main Feb 13, 2024
17 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 13, 2024
@darnautov darnautov deleted the ml-161248-embeddable-action branch February 13, 2024 16:15
@peteharverson peteharverson changed the title [ML] AIOps: UI action for Change Point Detection embeddable to open in the ML app [ML] AIOps: Adds UI action for Change Point Detection embeddable to open in the ML app Feb 14, 2024
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@darnautov @CoenWarmer
[ML] AIOps: UI action for Change Point Detection embeddable to open i…
2d92836 
…n the ML app (elastic#176694)

## Summary

Closes elastic#161248 

Added a UI action to open change point detection in the AIOps labs.

<img width="1137" alt="image"
src="https://github.com/elastic/kibana/assets/5236598/077c0e34-0ac0-4790-8cbe-c6048ee90d22">

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@darnautov @CoenWarmer
[ML] AIOps: UI action for Change Point Detection embeddable to open i…
1bc8564 
…n the ML app (elastic#176694)

## Summary

Closes elastic#161248 

Added a UI action to open change point detection in the AIOps labs.

<img width="1137" alt="image"
src="https://github.com/elastic/kibana/assets/5236598/077c0e34-0ac0-4790-8cbe-c6048ee90d22">

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@darnautov @fkanout
[ML] AIOps: UI action for Change Point Detection embeddable to open i…
064a8b8 
…n the ML app (elastic#176694)

## Summary

Closes elastic#161248 

Added a UI action to open change point detection in the AIOps labs.

<img width="1137" alt="image"
src="https://github.com/elastic/kibana/assets/5236598/077c0e34-0ac0-4790-8cbe-c6048ee90d22">

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@jloleysens jloleysens jloleysens approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

@darnautov darnautov

Labels
backport:skip This commit does not require backporting Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:enhancement v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] AIOps: Change point detection embeddables
7 participants
@darnautov @elasticmachine @kibana-ci @peteharverson @jloleysens @jgowdyelastic @kibanamachine