remove angular from AggTypes #17681
Merged
remove angular from AggTypes #17681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
added
WIP
💔 Build Failed |
|
jenkins, test this |
💔 Build Failed |
ppisljar
force-pushed
the
ang/removeAngularAggTypes
branch
from
88abce5
to
b5d05e6
Compare
ppisljar
changed the title
💔 Build Failed |
ppisljar
force-pushed
the
ang/removeAngularAggTypes
branch
from
b5d05e6
to
3249ce0
Compare
💔 Build Failed |
ppisljar
force-pushed
the
ang/removeAngularAggTypes
branch
from
3249ce0
to
4577138
Compare
💚 Build Succeeded |
ppisljar
force-pushed
the
ang/removeAngularAggTypes
branch
from
4577138
to
ef5392b
Compare
💔 Build Failed |
timroes
reviewed
Apr 18, 2018
| } | ||
|
|
||
|
|
||
| export const calcEsInterval = esDuration; |
There was a problem hiding this comment.
Could we use either export { esDuration as calcEsInterval }; syntax or just rename the above function to calcEsInterval and export { calcEsInterval };
💚 Build Succeeded |
timroes
reviewed
Apr 18, 2018
| { name: 'cumulative_sum', title: 'Cumulative Sum', provider: AggTypesMetricsCumulativeSumProvider }, | ||
| { name: 'moving_avg', title: 'Moving Avg', provider: AggTypesMetricsMovingAvgProvider }, | ||
| { name: 'serial_diff', title: 'Serial Diff', provider: AggTypesMetricsSerialDiffProvider }, | ||
| { name: 'derivative', title: 'Derivative', provider: derivativeMetricAgg }, |
There was a problem hiding this comment.
Maybe we could rename that field from provider to something like agg since it's not really a provider function anymore, that it might just be confusing that way?
timroes
approved these changes
Apr 18, 2018
💚 Build Succeeded |
thomasneirynck
approved these changes
Apr 18, 2018
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
May 7, 2018
# Conflicts: # src/ui/public/agg_response/point_series/__tests__/_fake_x_aspect.js # src/ui/public/agg_response/point_series/_fake_x_aspect.js # src/ui/public/agg_types/__tests__/agg_param_writer.js # src/ui/public/agg_types/__tests__/agg_type.js # src/ui/public/agg_types/__tests__/buckets/_geo_hash.js # src/ui/public/agg_types/__tests__/buckets/_histogram.js # src/ui/public/agg_types/__tests__/buckets/_terms_other_bucket_helper.js # src/ui/public/agg_types/__tests__/buckets/create_filter/date_histogram.js # src/ui/public/agg_types/__tests__/buckets/create_filter/date_range.js # src/ui/public/agg_types/__tests__/buckets/create_filter/filters.js # src/ui/public/agg_types/__tests__/buckets/create_filter/histogram.js # src/ui/public/agg_types/__tests__/buckets/create_filter/ip_range.js # src/ui/public/agg_types/__tests__/buckets/create_filter/range.js # src/ui/public/agg_types/__tests__/buckets/create_filter/terms.js # src/ui/public/agg_types/__tests__/buckets/date_histogram/_editor.js # src/ui/public/agg_types/__tests__/buckets/date_histogram/_params.js # src/ui/public/agg_types/__tests__/buckets/terms.js # src/ui/public/agg_types/__tests__/index.js # src/ui/public/agg_types/__tests__/metrics/parent_pipeline.js # src/ui/public/agg_types/__tests__/metrics/percentile_ranks.js # src/ui/public/agg_types/__tests__/metrics/percentiles.js # src/ui/public/agg_types/__tests__/metrics/sibling_pipeline.js # src/ui/public/agg_types/__tests__/metrics/std_deviation.js # src/ui/public/agg_types/__tests__/metrics/top_hit.js # src/ui/public/agg_types/buckets/_bucket_agg_type.js # src/ui/public/agg_types/buckets/_terms_other_bucket_helper.js # src/ui/public/agg_types/buckets/create_filter/date_range.js # src/ui/public/agg_types/buckets/date_histogram.js # src/ui/public/agg_types/buckets/date_range.js # src/ui/public/agg_types/buckets/filter.js # src/ui/public/agg_types/buckets/filters.js # src/ui/public/agg_types/buckets/geo_hash.js # src/ui/public/agg_types/buckets/histogram.js # src/ui/public/agg_types/buckets/ip_range.js # src/ui/public/agg_types/buckets/range.js # src/ui/public/agg_types/buckets/significant_terms.js # src/ui/public/agg_types/buckets/terms.js # src/ui/public/agg_types/index.js # src/ui/public/agg_types/metrics/avg.js # src/ui/public/agg_types/metrics/bucket_avg.js # src/ui/public/agg_types/metrics/bucket_max.js # src/ui/public/agg_types/metrics/bucket_min.js # src/ui/public/agg_types/metrics/bucket_sum.js # src/ui/public/agg_types/metrics/cardinality.js # src/ui/public/agg_types/metrics/count.js # src/ui/public/agg_types/metrics/cumulative_sum.js # src/ui/public/agg_types/metrics/derivative.js # src/ui/public/agg_types/metrics/geo_bounds.js # src/ui/public/agg_types/metrics/geo_centroid.js # src/ui/public/agg_types/metrics/max.js # src/ui/public/agg_types/metrics/median.js # src/ui/public/agg_types/metrics/metric_agg_type.js # src/ui/public/agg_types/metrics/min.js # src/ui/public/agg_types/metrics/moving_avg.js # src/ui/public/agg_types/metrics/percentile_ranks.js # src/ui/public/agg_types/metrics/percentiles.js # src/ui/public/agg_types/metrics/serial_diff.js # src/ui/public/agg_types/metrics/std_deviation.js # src/ui/public/agg_types/metrics/sum.js # src/ui/public/agg_types/metrics/top_hit.js # src/ui/public/courier/data_source/__tests__/decorate_query.js # src/ui/public/time_buckets/time_buckets.js # src/ui/public/vis/__tests__/_agg_config.js # src/ui/public/vis/agg_configs.js # src/ui/public/vis/editors/default/agg_params.js
ppisljar
added a commit
that referenced
this pull request
May 8, 2018
* remove angular from AggTypes (#17681) # Conflicts: # src/ui/public/agg_response/point_series/__tests__/_fake_x_aspect.js # src/ui/public/agg_response/point_series/_fake_x_aspect.js # src/ui/public/agg_types/__tests__/agg_param_writer.js # src/ui/public/agg_types/__tests__/agg_type.js # src/ui/public/agg_types/__tests__/buckets/_geo_hash.js # src/ui/public/agg_types/__tests__/buckets/_histogram.js # src/ui/public/agg_types/__tests__/buckets/_terms_other_bucket_helper.js # src/ui/public/agg_types/__tests__/buckets/create_filter/date_histogram.js # src/ui/public/agg_types/__tests__/buckets/create_filter/date_range.js # src/ui/public/agg_types/__tests__/buckets/create_filter/filters.js # src/ui/public/agg_types/__tests__/buckets/create_filter/histogram.js # src/ui/public/agg_types/__tests__/buckets/create_filter/ip_range.js # src/ui/public/agg_types/__tests__/buckets/create_filter/range.js # src/ui/public/agg_types/__tests__/buckets/create_filter/terms.js # src/ui/public/agg_types/__tests__/buckets/date_histogram/_editor.js # src/ui/public/agg_types/__tests__/buckets/date_histogram/_params.js # src/ui/public/agg_types/__tests__/buckets/terms.js # src/ui/public/agg_types/__tests__/index.js # src/ui/public/agg_types/__tests__/metrics/parent_pipeline.js # src/ui/public/agg_types/__tests__/metrics/percentile_ranks.js # src/ui/public/agg_types/__tests__/metrics/percentiles.js # src/ui/public/agg_types/__tests__/metrics/sibling_pipeline.js # src/ui/public/agg_types/__tests__/metrics/std_deviation.js # src/ui/public/agg_types/__tests__/metrics/top_hit.js # src/ui/public/agg_types/buckets/_bucket_agg_type.js # src/ui/public/agg_types/buckets/_terms_other_bucket_helper.js # src/ui/public/agg_types/buckets/create_filter/date_range.js # src/ui/public/agg_types/buckets/date_histogram.js # src/ui/public/agg_types/buckets/date_range.js # src/ui/public/agg_types/buckets/filter.js # src/ui/public/agg_types/buckets/filters.js # src/ui/public/agg_types/buckets/geo_hash.js # src/ui/public/agg_types/buckets/histogram.js # src/ui/public/agg_types/buckets/ip_range.js # src/ui/public/agg_types/buckets/range.js # src/ui/public/agg_types/buckets/significant_terms.js # src/ui/public/agg_types/buckets/terms.js # src/ui/public/agg_types/index.js # src/ui/public/agg_types/metrics/avg.js # src/ui/public/agg_types/metrics/bucket_avg.js # src/ui/public/agg_types/metrics/bucket_max.js # src/ui/public/agg_types/metrics/bucket_min.js # src/ui/public/agg_types/metrics/bucket_sum.js # src/ui/public/agg_types/metrics/cardinality.js # src/ui/public/agg_types/metrics/count.js # src/ui/public/agg_types/metrics/cumulative_sum.js # src/ui/public/agg_types/metrics/derivative.js # src/ui/public/agg_types/metrics/geo_bounds.js # src/ui/public/agg_types/metrics/geo_centroid.js # src/ui/public/agg_types/metrics/max.js # src/ui/public/agg_types/metrics/median.js # src/ui/public/agg_types/metrics/metric_agg_type.js # src/ui/public/agg_types/metrics/min.js # src/ui/public/agg_types/metrics/moving_avg.js # src/ui/public/agg_types/metrics/percentile_ranks.js # src/ui/public/agg_types/metrics/percentiles.js # src/ui/public/agg_types/metrics/serial_diff.js # src/ui/public/agg_types/metrics/std_deviation.js # src/ui/public/agg_types/metrics/sum.js # src/ui/public/agg_types/metrics/top_hit.js # src/ui/public/courier/data_source/__tests__/decorate_query.js # src/ui/public/time_buckets/time_buckets.js # src/ui/public/vis/__tests__/_agg_config.js # src/ui/public/vis/agg_configs.js # src/ui/public/vis/editors/default/agg_params.js * updating x-pack
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove angular from AggTypes (unwrapping providers only, no functional changes)