remove angular from AggConfigs #17682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
added
WIP
💔 Build Failed |
ppisljar
force-pushed
the
ang/removeAngularAggConfigs2
branch
from
097773f
to
b6d2b05
Compare
💔 Build Failed |
ppisljar
force-pushed
the
ang/removeAngularAggConfigs2
branch
from
b6d2b05
to
aafa31c
Compare
💚 Build Succeeded |
ppisljar
commented
Apr 18, 2018
| @@ -29,6 +29,7 @@ function AggConfig(vis, opts) { | |||
| self.setParams(opts.params || {}); | |||
| } | |||
|
|
|||
| AggConfig.aggTypes = aggTypes; | |||
There was a problem hiding this comment.
moved from AggConfigs to AggConfig directly
ppisljar
force-pushed
the
ang/removeAngularAggConfigs2
branch
from
aafa31c
to
5d626fe
Compare
💚 Build Succeeded |
ppisljar
force-pushed
the
ang/removeAngularAggConfigs2
branch
from
5d626fe
to
d25408e
Compare
ppisljar
changed the title
💚 Build Succeeded |
timroes
approved these changes
May 4, 2018
thomasneirynck
approved these changes
May 4, 2018
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
May 8, 2018
# Conflicts: # src/ui/public/agg_types/__tests__/buckets/_geo_hash.js
ppisljar
added a commit
that referenced
this pull request
May 8, 2018
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove angular from AggConfigs