Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.13] [ResponseOps][FE] Alert creation delay based on user definition (#176346) #177051

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.13:

Questions ?

Please refer to the Backport tool documentation

…tic#176346)

Resolves elastic#173009

## Summary

Adds a new input for the user to define the `alertDelay`. This input is
available for life-cycled alerts (stack and o11y) rule types.

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### To verify

- Using the UI create a rule with the `alertDelay` field set.
- Verify that the field is saved properly and that you can edit the
`alertDelay`
- Verify that you can add the alert delay to existing rules. Create a
rule in a different branch and switch to this one. Edit the rule and set
the `alertDelay`. Verify that the rule saves and works as expected.

---------

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
(cherry picked from commit 68d6ab2)
@kibanamachine kibanamachine merged commit 234ef3d into elastic:8.13 Feb 15, 2024
39 checks passed
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #4 / CustomFields renders correctly
  • [job] [logs] Jest Tests #4 / UserActionMarkdown errors Shows error message and save button disabled if current text is empty
  • [job] [logs] Jest Tests #4 / UserActionMarkdown errors Shows error message and save button disabled if current text is of empty characters
  • [job] [logs] Jest Tests #4 / UserActionMarkdown errors Shows error message and save button disabled if current text is too long
  • [job] [logs] Jest Tests #4 / UserActionMarkdown useForm stale state bug doesn't create a stale state if a key is passed to the component

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.6MB +1.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 108.2KB 108.2KB +37.0B
Unknown metric groups

References to deprecated APIs

id before after diff
triggersActionsUi 53 54 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @doakalexi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants