Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http.payloadTimeout config option #177309

Merged
merged 6 commits into from
Feb 22, 2024

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Feb 20, 2024

Summary

Fix #177138

  • Add a http.payloadTimeout configuration option, to control the payload timeout
  • Set the default value for this option to 20s (was 10s previously)

@pgayvallet pgayvallet added Feature:http Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.14.0 labels Feb 20, 2024
@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/core-http-server-internal 72 73 +1
@kbn/server-http-tools 57 58 +1
total +2
Unknown metric groups

API count

id before after diff
@kbn/core-http-server-internal 84 85 +1
@kbn/server-http-tools 61 62 +1
total +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet marked this pull request as ready for review February 22, 2024 10:43
@pgayvallet pgayvallet requested review from a team as code owners February 22, 2024 10:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet pgayvallet added v8.13.0 release_note:skip Skip the PR/issue when compiling release notes labels Feb 22, 2024
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 🚢

@pgayvallet pgayvallet merged commit 38a3b96 into elastic:main Feb 22, 2024
21 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 22, 2024
## Summary

Fix elastic#177138

- Add a `http.payloadTimeout` configuration option, to control the
payload timeout
- Set the default value for this option to `20s` (was `10s` previously)

(cherry picked from commit 38a3b96)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 22, 2024
…177574)

# Backport

This will backport the following commits from `main` to `8.13`:
- [Add `http.payloadTimeout` config option
(#177309)](#177309)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pierre
Gayvallet","email":"pierre.gayvallet@elastic.co"},"sourceCommit":{"committedDate":"2024-02-22T11:33:49Z","message":"Add
`http.payloadTimeout` config option (#177309)\n\n## Summary\r\n\r\nFix
#177138 Add a
`http.payloadTimeout` configuration option, to control the\r\npayload
timeout\r\n- Set the default value for this option to `20s` (was `10s`
previously)","sha":"38a3b9675d5fd7ab97b9b7a6394df67a4074de01","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:http","Team:Core","release_note:skip","v8.13.0","v8.14.0"],"title":"Add
`http.payloadTimeout` config
option","number":177309,"url":"#177309
`http.payloadTimeout` config option (#177309)\n\n## Summary\r\n\r\nFix
#177138 Add a
`http.payloadTimeout` configuration option, to control the\r\npayload
timeout\r\n- Set the default value for this option to `20s` (was `10s`
previously)","sha":"38a3b9675d5fd7ab97b9b7a6394df67a4074de01"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"#177309
`http.payloadTimeout` config option (#177309)\n\n## Summary\r\n\r\nFix
#177138 Add a
`http.payloadTimeout` configuration option, to control the\r\npayload
timeout\r\n- Set the default value for this option to `20s` (was `10s`
previously)","sha":"38a3b9675d5fd7ab97b9b7a6394df67a4074de01"}}]}]
BACKPORT-->

Co-authored-by: Pierre Gayvallet <pierre.gayvallet@elastic.co>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
## Summary

Fix elastic#177138

- Add a `http.payloadTimeout` configuration option, to control the
payload timeout
- Set the default value for this option to `20s` (was `10s` previously)
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request May 7, 2024
@pgayvallet
Copy link
Contributor Author

Backport to 7.17: #182838

pgayvallet added a commit that referenced this pull request May 8, 2024
## Summary

Manual backport of #177309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:http release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.17.22 v8.13.0 v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HTTP server] Add config option for default payload timeout
6 participants