Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Moving] Move Dataset Quality folder into /x-pack/observability_solution #177456

Merged
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ src/plugins/data_view_management @elastic/kibana-data-discovery
packages/kbn-data-view-utils @elastic/kibana-data-discovery
src/plugins/data_views @elastic/kibana-data-discovery
x-pack/plugins/data_visualizer @elastic/ml-ui
x-pack/plugins/dataset_quality @elastic/obs-ux-logs-team
x-pack/plugins/observability_solution/dataset_quality @elastic/obs-ux-logs-team
packages/kbn-datemath @elastic/kibana-data-discovery
packages/deeplinks/analytics @elastic/kibana-data-discovery @elastic/kibana-presentation @elastic/kibana-visualizations
packages/deeplinks/devtools @elastic/platform-deployment-management
Expand Down
22 changes: 11 additions & 11 deletions api_docs/dataset_quality.devdocs.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"tags": [],
"label": "datasetQualityAppTitle",
"description": [],
"path": "x-pack/plugins/dataset_quality/common/translations.ts",
"path": "x-pack/plugins/observability_solution/dataset_quality/common/translations.ts",
"deprecated": false,
"trackAdoption": false,
"initialIsOpen": false
Expand All @@ -27,7 +27,7 @@
"tags": [],
"label": "DatasetQualityPluginSetup",
"description": [],
"path": "x-pack/plugins/dataset_quality/public/types.ts",
"path": "x-pack/plugins/observability_solution/dataset_quality/public/types.ts",
"deprecated": false,
"trackAdoption": false,
"children": [],
Expand All @@ -41,7 +41,7 @@
"tags": [],
"label": "DatasetQualityPluginStart",
"description": [],
"path": "x-pack/plugins/dataset_quality/public/types.ts",
"path": "x-pack/plugins/observability_solution/dataset_quality/public/types.ts",
"deprecated": false,
"trackAdoption": false,
"children": [
Expand All @@ -59,7 +59,7 @@
"DatasetQualityProps",
">"
],
"path": "x-pack/plugins/dataset_quality/public/types.ts",
"path": "x-pack/plugins/observability_solution/dataset_quality/public/types.ts",
"deprecated": false,
"trackAdoption": false
},
Expand All @@ -77,7 +77,7 @@
"DatasetQualityController",
">"
],
"path": "x-pack/plugins/dataset_quality/public/types.ts",
"path": "x-pack/plugins/observability_solution/dataset_quality/public/types.ts",
"deprecated": false,
"trackAdoption": false,
"returnComment": [],
Expand All @@ -94,7 +94,7 @@
"DatasetQualityPublicState",
"> | undefined; }"
],
"path": "x-pack/plugins/dataset_quality/public/controller/create_controller.ts",
"path": "x-pack/plugins/observability_solution/dataset_quality/public/controller/create_controller.ts",
"deprecated": false,
"trackAdoption": false
}
Expand Down Expand Up @@ -124,7 +124,7 @@
"tags": [],
"label": "DatasetQualityConfig",
"description": [],
"path": "x-pack/plugins/dataset_quality/common/plugin_config.ts",
"path": "x-pack/plugins/observability_solution/dataset_quality/common/plugin_config.ts",
"deprecated": false,
"trackAdoption": false,
"children": [],
Expand Down Expand Up @@ -227,7 +227,7 @@
},
" ? ClientRequestParamsOfType<TRouteParamsRT> : {} : never"
],
"path": "x-pack/plugins/dataset_quality/common/rest/create_call_dataset_quality_api.ts",
"path": "x-pack/plugins/observability_solution/dataset_quality/common/rest/create_call_dataset_quality_api.ts",
"deprecated": false,
"trackAdoption": false,
"initialIsOpen": false
Expand Down Expand Up @@ -310,7 +310,7 @@
"ServerRouteCreateOptions",
" ? TReturnType : never"
],
"path": "x-pack/plugins/dataset_quality/common/rest/create_call_dataset_quality_api.ts",
"path": "x-pack/plugins/observability_solution/dataset_quality/common/rest/create_call_dataset_quality_api.ts",
"deprecated": false,
"trackAdoption": false,
"initialIsOpen": false
Expand All @@ -333,12 +333,12 @@
},
", \"body\"> & { pathname: string; method?: string | undefined; body?: any; }"
],
"path": "x-pack/plugins/dataset_quality/common/fetch_options.ts",
"path": "x-pack/plugins/observability_solution/dataset_quality/common/fetch_options.ts",
"deprecated": false,
"trackAdoption": false,
"initialIsOpen": false
}
],
"objects": []
}
}
}
1 change: 0 additions & 1 deletion api_docs/dataset_quality.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,3 @@ Contact [@elastic/obs-ux-logs-team](https://github.com/orgs/elastic/teams/obs-ux

### Consts, variables and types
<DocDefinitionList data={datasetQualityObj.common.misc}/>

2 changes: 1 addition & 1 deletion docs/developer/plugin-list.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ Plugin server-side only. Plugin has three main functions:
|Adds drilldown capabilities to dashboard. Owned by the Kibana App team.


|{kib-repo}blob/{branch}/x-pack/plugins/dataset_quality/README.md[datasetQuality]
|{kib-repo}blob/{branch}/x-pack/plugins/observability_solution/dataset_quality/README.md[datasetQuality]
|In order to make ongoing maintenance of log collection easy we want to introduce the concept of dataset quality, where users can easily get an overview on the datasets they have with information such as integration, size, last activity, among others.


Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@
"@kbn/data-view-utils": "link:packages/kbn-data-view-utils",
"@kbn/data-views-plugin": "link:src/plugins/data_views",
"@kbn/data-visualizer-plugin": "link:x-pack/plugins/data_visualizer",
"@kbn/dataset-quality-plugin": "link:x-pack/plugins/dataset_quality",
"@kbn/dataset-quality-plugin": "link:x-pack/plugins/observability_solution/dataset_quality",
"@kbn/datemath": "link:packages/kbn-datemath",
"@kbn/deeplinks-analytics": "link:packages/deeplinks/analytics",
"@kbn/deeplinks-devtools": "link:packages/deeplinks/devtools",
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -648,8 +648,8 @@
"@kbn/data-views-plugin/*": ["src/plugins/data_views/*"],
"@kbn/data-visualizer-plugin": ["x-pack/plugins/data_visualizer"],
"@kbn/data-visualizer-plugin/*": ["x-pack/plugins/data_visualizer/*"],
"@kbn/dataset-quality-plugin": ["x-pack/plugins/dataset_quality"],
"@kbn/dataset-quality-plugin/*": ["x-pack/plugins/dataset_quality/*"],
"@kbn/dataset-quality-plugin": ["x-pack/plugins/observability_solution/dataset_quality"],
"@kbn/dataset-quality-plugin/*": ["x-pack/plugins/observability_solution/dataset_quality/*"],
"@kbn/datemath": ["packages/kbn-datemath"],
"@kbn/datemath/*": ["packages/kbn-datemath/*"],
"@kbn/deeplinks-analytics": ["packages/deeplinks/analytics"],
Expand Down
2 changes: 1 addition & 1 deletion x-pack/.i18nrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"xpack.csp": "plugins/cloud_security_posture",
"xpack.customBranding": "plugins/custom_branding",
"xpack.dashboard": "plugins/dashboard_enhanced",
"xpack.datasetQuality": "plugins/dataset_quality",
"xpack.datasetQuality": "plugins/observability_solution/dataset_quality",
"xpack.discover": "plugins/discover_enhanced",
"xpack.crossClusterReplication": "plugins/cross_cluster_replication",
"xpack.elasticAssistant": "packages/kbn-elastic-assistant",
Expand Down
15 changes: 0 additions & 15 deletions x-pack/plugins/dataset_quality/jest.config.js

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ In order to make ongoing maintenance of log collection easy we want to introduce
Kibana primarily uses Jest for unit testing. Each plugin or package defines a `jest.config.js` that extends a preset provided by the `@kbn/test` package. The following command runs all Dataset quality unit tests:

```
yarn jest --config x-pack/plugins/dataset_quality/jest.config.js
yarn jest --config x-pack/plugins/observability_solution/dataset_quality/jest.config.js
```

You can also run a specific test by passing the filepath as an argument, e.g.:

```
yarn jest --config x-pack/plugins/dataset_quality/jest.config.js x-pack/plugins/dataset_quality/server/routes/data_streams/get_data_streams/get_data_streams.test.ts
yarn jest --config x-pack/plugins/observability_solution/dataset_quality/jest.config.js x-pack/plugins/observability_solution/dataset_quality/server/routes/data_streams/get_data_streams/get_data_streams.test.ts
```

#### API integration tests
Expand All @@ -36,7 +36,7 @@ The API tests are located in [`x-pack/test/dataset_quality_api_integration/`](/x
#### Start server and run test (single process)

```
node x-pack/plugins/dataset_quality/scripts/api [--help]
node x-pack/plugins/observability_solution/dataset_quality/scripts/api [--help]
```

The above command will start an ES instance on http://localhost:9220, a Kibana instance on http://localhost:5620 and run the api tests.
Expand All @@ -46,8 +46,8 @@ Once the tests finish, the instances will be terminated.

```sh
# start server
node x-pack/plugins/dataset_quality/scripts/api --server
node x-pack/plugins/observability_solution/dataset_quality/scripts/api --server

# run tests
node x-pack/plugins/dataset_quality/scripts/api --runner --grep-files=error_group_list
node x-pack/plugins/observability_solution/dataset_quality/scripts/api --runner --grep-files=error_group_list
```
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/

module.exports = {
preset: '@kbn/test',
rootDir: '../../../..',
roots: ['<rootDir>/x-pack/plugins/observability_solution/dataset_quality'],
coverageDirectory:
'<rootDir>/target/kibana-coverage/jest/x-pack/plugins/observability_solution/dataset_quality',
coverageReporters: ['text', 'html'],
collectCoverageFrom: [
'<rootDir>/x-pack/plugins/observability_solution/dataset_quality/{common,public}/**/*.{ts,tsx}',
],
};
Original file line number Diff line number Diff line change
@@ -1,14 +1,9 @@
{
"extends": "../../../tsconfig.base.json",
"extends": "../../../../tsconfig.base.json",
"compilerOptions": {
"outDir": "target/types"
},
"include": [
"common/**/*",
"public/**/*",
"server/**/*",
"../../../typings/**/*",
],
"include": ["common/**/*", "public/**/*", "server/**/*", "../../../../typings/**/*"],
"kbn_references": [
"@kbn/core",
"@kbn/core-plugins-server",
Expand Down Expand Up @@ -38,7 +33,5 @@
"@kbn/unified-search-plugin",
"@kbn/timerange"
],
"exclude": [
"target/**/*",
]
"exclude": ["target/**/*"]
}
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4365,7 +4365,7 @@
version "0.0.0"
uid ""

"@kbn/dataset-quality-plugin@link:x-pack/plugins/dataset_quality":
"@kbn/dataset-quality-plugin@link:x-pack/plugins/observability_solution/dataset_quality":
version "0.0.0"
uid ""

Expand Down