Pause refresh when page is hidden

[Dosant]

Summary

close #1878

Pauses auto-refresh when a page is not visible.
I tested and didn't notice any issues, but looking for more testing help

Release Notes

Auto-refresh pauses when the page is not visible.

[Dosant]

/ci

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[elasticmachine]

Pinging @elastic/kibana-visualizations (Team:Visualizations)

[elasticmachine]

Pinging @elastic/appex-sharedux (Team:SharedUX)

[timductive]

Nice work @Dosant can we also track impact of this in our cloud telemetry after release? Ideally we would see a reduction in proxy logs or something like that.

[lukasolson]

Hmm, I'm noticing in Discover (not in Lens) we still seem to get refreshes even when the page is not visible. I've set the refresh interval to 5s and when I switch tabs I'm still getting refreshes every 30s or so.

After putting in some log statements it looks like these refreshes for some reason are not initiated by this code (I'm not getting any events from tickWhenVisible$), so I think we are still good to move forward with this change... But we will want to do some additional investigation on the Discover side as to why these search requests are still being fired.

Anyway, changes LGTM!

[mbondyra]

Noticed the same thing as @lukasolson, but it is a great improvement for Lens and Dashboard so approving! Hopefully we'll fix the discover case too 😊

[Dosant]

can we also track impact of this in our cloud telemetry after release? Ideally we would see a reduction in proxy logs or something like that.

@timductive, I doubt we will be able to see the impact. I am not sure how we can only filter in the excessive traffic caused by auto-refresh while in the background to measure its impact

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 9c63dd1

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
data	495	496	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
data	415.4KB	415.7KB	+287.0B

History

• 💛 Build #195222 was flaky b93afae

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[Dosant]

@lukasolson, we with @mbondyra found the possible reason for the refetches in the background:

Looks like there are coming from this snippet

kibana/src/plugins/data/public/search/session/session_service.ts

Lines 304 to 334 in a3edafa

	const schedulePollSearches = () => {
	return timer(KEEP_ALIVE_COMPLETED_SEARCHES_INTERVAL).pipe(
	mergeMap(() => {
	const searchesToKeepAlive = this.state.get().trackedSearches.filter(
	(s) =>
	!s.searchMeta.isStored &&
	s.state === TrackedSearchState.Completed &&
	s.searchMeta.lastPollingTime.getTime() < Date.now() - 5000 // don't poll if was very recently polled
	);
	return from(
	Promise.all(
	searchesToKeepAlive.map((s) =>
	s.searchDescriptor.poll().catch((e) => {
	// eslint-disable-next-line no-console
	console.warn(
	`Error while polling search to keep it alive. Considering that it is no longer possible to extend a session.`,
	e
	);
	if (this.isCurrentSession(sessionId)) {
	this._disableSaveAfterSearchesExpire$.next(true);
	}
	})
	)
	)
	);
	}),
	repeat(),
	takeUntil(this.disableSaveAfterSearchesExpire$.pipe(filter((disable) => disable)))
	);
	};

where we're keeping the async searches alive for 5 minutes with 30s interval.
Btw, the same should happen on a dashboard with an async search panel (e.g lens)

So these refreshes are expected and we won't get rid of them without disabling search sessions