Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add significant terms in tag cloud visualization #17770

Merged
merged 3 commits into from Apr 25, 2018

Conversation

Projects
None yet
6 participants
@timroes
Copy link
Contributor

commented Apr 18, 2018

Resolves #9502

You can now use significant terms aggregation in tagcloud.

@elasticmachine

This comment has been minimized.

Copy link

commented Apr 18, 2018

@timroes timroes removed the v6.3.0 label Apr 18, 2018

@elasticmachine

This comment has been minimized.

Copy link

commented Apr 18, 2018

@@ -92,7 +92,11 @@ export class TagCloudVisualization {
}

const data = response.tables[0];
this._bucketAgg = this._vis.aggs.find(agg => agg.type.name === 'terms');
if (this._vis.aggs.bySchemaName.segment) {
this._bucketAgg = this._vis.aggs.bySchemaName.segment[0];

This comment has been minimized.

Copy link
@ppisljar

ppisljar Apr 19, 2018

Member

this might throw, if segment doesn't have any elements ... maybe use lodash ?
this._bucketAgg = _.get(this, '_vis.aggs.bySchemaName.segment[0]', null)

@elasticmachine

This comment has been minimized.

Copy link

commented Apr 20, 2018

@timroes timroes added the v6.4.0 label Apr 25, 2018

@ppisljar
Copy link
Member

left a comment

LGTM

@timroes timroes merged commit ef86570 into elastic:master Apr 25, 2018

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

@timroes timroes deleted the timroes:tagcloud-sig-term branch Apr 25, 2018

timroes added a commit to timroes/kibana that referenced this pull request Apr 25, 2018

Add significant terms in tag cloud visualization (elastic#17770)
* Allow significant terms for tag cloud

* Fix request before terms aggregation has configured

* Check if at least one agg is in array
@jccq

This comment has been minimized.

Copy link

commented Apr 25, 2018

significant term returns 2 values, the significance and the count they are both important. Would it be possible to have one on the size of the term and the other say on the hint on hoover?

@timroes

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2018

@jccq Please feel free to open a feature request, to add tooltips to tag cloud in general. Currently Tagcloud doesn't show any tooltips, so the values could be shown (as in other charts) in a tooltip.

timroes added a commit that referenced this pull request Apr 25, 2018

Add significant terms in tag cloud visualization (#17770) (#18560)
* Allow significant terms for tag cloud

* Fix request before terms aggregation has configured

* Check if at least one agg is in array
@markharwood

This comment has been minimized.

Copy link
Contributor

commented May 3, 2018

Significant terms agg should really be used for structured fields only.
The new significant_text agg is targetted for use on text fields (note it is advisable to combine with the sampler agg to sample only the top-matching docs.) Consider also the de-dup feature in that agg which typically greatly improves the quality of results - example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.