Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] fix: update vector search snippets to use try in console button #178402

Conversation

TattdCodeMonkey
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey commented Mar 11, 2024

Summary

Updating the Vector Search page to use the shared Try In Console button, and then fixing the layout issues from using it.

This ensures that the code snippets can be used in the Persistent console instead of opening a new tab.

image

@TattdCodeMonkey TattdCodeMonkey added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.14.0 v8.13.1 labels Mar 11, 2024
@TattdCodeMonkey TattdCodeMonkey requested a review from a team as a code owner March 11, 2024 15:36
@efegurkan
Copy link
Member

Checks are failing due to an unused translation, otherwise LGTM

@TattdCodeMonkey TattdCodeMonkey force-pushed the rnorris/fix/vector-search-try-in-console branch from 954828a to e13b339 Compare March 11, 2024 18:33
@TattdCodeMonkey TattdCodeMonkey enabled auto-merge (squash) March 11, 2024 18:33
@kibana-ci
Copy link
Collaborator

kibana-ci commented Mar 11, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #7 / RegisteredAttachmentsPropertyActions renders the correct number of actions

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.8MB 2.8MB +367.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TattdCodeMonkey TattdCodeMonkey merged commit 714796b into elastic:main Mar 11, 2024
16 of 17 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 11, 2024
…ton (elastic#178402)

## Summary

Updating the Vector Search page to use the shared Try In Console button,
and then fixing the layout issues from using it.

This ensures that the code snippets can be used in the Persistent
console instead of opening a new tab.

![image](https://github.com/elastic/kibana/assets/1972968/6be12953-060f-47b6-a7b8-30896a35e112)

(cherry picked from commit 714796b)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@TattdCodeMonkey TattdCodeMonkey deleted the rnorris/fix/vector-search-try-in-console branch March 11, 2024 21:48
kibanamachine added a commit that referenced this pull request Mar 11, 2024
…ole button (#178402) (#178453)

# Backport

This will backport the following commits from `main` to `8.13`:
- [[Search] fix: update vector search snippets to use try in console
button (#178402)](#178402)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Rodney
Norris","email":"rodney.norris@elastic.co"},"sourceCommit":{"committedDate":"2024-03-11T21:15:33Z","message":"[Search]
fix: update vector search snippets to use try in console button
(#178402)\n\n## Summary\r\n\r\nUpdating the Vector Search page to use
the shared Try In Console button,\r\nand then fixing the layout issues
from using it.\r\n\r\nThis ensures that the code snippets can be used in
the Persistent\r\nconsole instead of opening a new
tab.\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/1972968/6be12953-060f-47b6-a7b8-30896a35e112)","sha":"714796b9c3c5d43f0681ebf6a58f36ad56e8bcf3","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.14.0","v8.13.1"],"title":"[Search]
fix: update vector search snippets to use try in console
button","number":178402,"url":"#178402
fix: update vector search snippets to use try in console button
(#178402)\n\n## Summary\r\n\r\nUpdating the Vector Search page to use
the shared Try In Console button,\r\nand then fixing the layout issues
from using it.\r\n\r\nThis ensures that the code snippets can be used in
the Persistent\r\nconsole instead of opening a new
tab.\r\n\r\n\r\n![image](#178402
fix: update vector search snippets to use try in console button
(#178402)\n\n## Summary\r\n\r\nUpdating the Vector Search page to use
the shared Try In Console button,\r\nand then fixing the layout issues
from using it.\r\n\r\nThis ensures that the code snippets can be used in
the Persistent\r\nconsole instead of opening a new
tab.\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/1972968/6be12953-060f-47b6-a7b8-30896a35e112)","sha":"714796b9c3c5d43f0681ebf6a58f36ad56e8bcf3"}},{"branch":"8.13","label":"v8.13.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Rodney Norris <rodney.norris@elastic.co>
eokoneyo pushed a commit to eokoneyo/kibana that referenced this pull request Mar 19, 2024
…ton (elastic#178402)

## Summary

Updating the Vector Search page to use the shared Try In Console button,
and then fixing the layout issues from using it.

This ensures that the code snippets can be used in the Persistent
console instead of opening a new tab.


![image](https://github.com/elastic/kibana/assets/1972968/6be12953-060f-47b6-a7b8-30896a35e112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants