-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search] fix: update vector search snippets to use try in console button #178402
Merged
TattdCodeMonkey
merged 1 commit into
elastic:main
from
TattdCodeMonkey:rnorris/fix/vector-search-try-in-console
Mar 11, 2024
Merged
[Search] fix: update vector search snippets to use try in console button #178402
TattdCodeMonkey
merged 1 commit into
elastic:main
from
TattdCodeMonkey:rnorris/fix/vector-search-try-in-console
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TattdCodeMonkey
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:EnterpriseSearch
v8.14.0
v8.13.1
labels
Mar 11, 2024
efegurkan
approved these changes
Mar 11, 2024
Checks are failing due to an unused translation, otherwise LGTM |
TattdCodeMonkey
force-pushed
the
rnorris/fix/vector-search-try-in-console
branch
from
March 11, 2024 18:33
954828a
to
e13b339
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 11, 2024
…ton (elastic#178402) ## Summary Updating the Vector Search page to use the shared Try In Console button, and then fixing the layout issues from using it. This ensures that the code snippets can be used in the Persistent console instead of opening a new tab. ![image](https://github.com/elastic/kibana/assets/1972968/6be12953-060f-47b6-a7b8-30896a35e112) (cherry picked from commit 714796b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 11, 2024
…ole button (#178402) (#178453) # Backport This will backport the following commits from `main` to `8.13`: - [[Search] fix: update vector search snippets to use try in console button (#178402)](#178402) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rodney Norris","email":"rodney.norris@elastic.co"},"sourceCommit":{"committedDate":"2024-03-11T21:15:33Z","message":"[Search] fix: update vector search snippets to use try in console button (#178402)\n\n## Summary\r\n\r\nUpdating the Vector Search page to use the shared Try In Console button,\r\nand then fixing the layout issues from using it.\r\n\r\nThis ensures that the code snippets can be used in the Persistent\r\nconsole instead of opening a new tab.\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/1972968/6be12953-060f-47b6-a7b8-30896a35e112)","sha":"714796b9c3c5d43f0681ebf6a58f36ad56e8bcf3","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.14.0","v8.13.1"],"title":"[Search] fix: update vector search snippets to use try in console button","number":178402,"url":"#178402 fix: update vector search snippets to use try in console button (#178402)\n\n## Summary\r\n\r\nUpdating the Vector Search page to use the shared Try In Console button,\r\nand then fixing the layout issues from using it.\r\n\r\nThis ensures that the code snippets can be used in the Persistent\r\nconsole instead of opening a new tab.\r\n\r\n\r\n![image](#178402 fix: update vector search snippets to use try in console button (#178402)\n\n## Summary\r\n\r\nUpdating the Vector Search page to use the shared Try In Console button,\r\nand then fixing the layout issues from using it.\r\n\r\nThis ensures that the code snippets can be used in the Persistent\r\nconsole instead of opening a new tab.\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/1972968/6be12953-060f-47b6-a7b8-30896a35e112)","sha":"714796b9c3c5d43f0681ebf6a58f36ad56e8bcf3"}},{"branch":"8.13","label":"v8.13.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Rodney Norris <rodney.norris@elastic.co>
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Mar 19, 2024
…ton (elastic#178402) ## Summary Updating the Vector Search page to use the shared Try In Console button, and then fixing the layout issues from using it. This ensures that the code snippets can be used in the Persistent console instead of opening a new tab. ![image](https://github.com/elastic/kibana/assets/1972968/6be12953-060f-47b6-a7b8-30896a35e112)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:EnterpriseSearch
v8.13.0
v8.13.1
v8.14.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating the Vector Search page to use the shared Try In Console button, and then fixing the layout issues from using it.
This ensures that the code snippets can be used in the Persistent console instead of opening a new tab.