Upgrade EUI to v93.4.0 #178890
Merged
Upgrade EUI to v93.4.0 #178890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
release_note:skip
- cell actions was covering the click element - adding a `moveMouseTo` fixes the issue
cee-chen
force-pushed
the
eui/v93.4.0
branch
2 times, most recently
from
dc405d2
to
4e3769a
Compare
- checkbox click is happening before datagrid is done loading which is causing the selection to unset
|
/ci |
|
Pinging @elastic/eui-team (EUI) |
cee-chen
commented
Mar 19, 2024
| @@ -1,6 +1,5 @@ | |||
| // Charts themes available app-wide | |||
| @import '@elastic/charts/dist/theme'; | |||
| @import '@elastic/eui/src/themes/charts/theme'; | |||
There was a problem hiding this comment.
@nickofthyme Would appreciate your help QAing this and confirming that the removed .echAnnotation CSS does not materially affect Kibana (see elastic/eui#7572 (review))
There was a problem hiding this comment.
@cee-chen did a check around kibana and see no impact of removing these styles.
botelastic
bot
added
the
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Ikuni17
approved these changes
Mar 19, 2024
pgayvallet
approved these changes
Mar 20, 2024
cauemarcondes
approved these changes
Mar 20, 2024
jsanz
approved these changes
Mar 20, 2024
semd
reviewed
Mar 20, 2024
x-pack/test/security_solution_cypress/cypress/tasks/hosts/events.ts
Outdated
Show resolved
Hide resolved
semd
approved these changes
Mar 20, 2024
ryankeairns
approved these changes
Mar 21, 2024
tsullivan
approved these changes
Mar 21, 2024
nickofthyme
approved these changes
Mar 21, 2024
| const ColumnSorting = useDataGridColumnSorting({ | ||
| columns: myColumns, | ||
| sorting: sortedColumns, | ||
| schema: {}, |
There was a problem hiding this comment.
not that it wasn't like this before, but this and the array below should be a stable reference probably
kqualters-elastic
approved these changes
Mar 22, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v93.3.0⏩v93.4.0v93.4.0EuiButtonGroup'soptionsconfigs:toolTipContent,toolTipProps, andtitle. These new properties allow wrapping buttons inEuiToolTips, and additionally customizing or disabling the native browsertitletooltip. (#7461)EuiResizeObserveranduseResizeObserver's performance to not trigger page reflows on resize event (#7575)EuiSuperUpdateButtonto support custom button text via an optionalchildrenprop (#7576)Bug fixes
EuiFlyoutto not repeatedly remove/add a body class on resize (#7462)EuiToasttitle text to wrap instead of overflowing out of the container (#7568)EuiHeaderBreadcrumbswith popovers (#7580)Deprecations
euiPalettePositiveandeuiPaletteNegativein favour of a more culturally inclusiveeuiPaletteGreenandeuiPaletteRed(#7570)@elastic/chartsexports: (#7572)EUI_CHARTS_THEME_<DARK|LIGHT>in favor of<DARK|LIGHT>_THEMEfrom@elastic/charts. (#7572)EUI_SPARKLINE_THEME_PARTIALin favor ofuseSparklineOverridestheme from the kibanachartspluginthemeservice.Accessibility
EuiModalto set anaria-modalattribute and a defaultdialogrole (#7564)EuiConfirmModalto set a defaultalertdialogrole (#7564)EuiModalandEuiConfirmModalto properly trap Safari+VoiceOver's virtual cursor (#7564)