[ES|QL] Fix wilcard complex scenarios #178938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dej611
added
release_note:fix
Team:Visualizations
|
/ci |
|
/ci |
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
18 tasks
|
This one?? 😄 Although the first asterisk is reduntant It work in es side and we should not mark it as invalid. 
|
|
With dbb3d08 it should be fixed @stratoula . I've added also a test case to avoid regressions |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
stratoula
approved these changes
Mar 20, 2024
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dej611
added a commit
to dej611/kibana
that referenced
this pull request
Mar 21, 2024
Improves the wildcard validation logic to handle multiple occurrencies of wildcards. Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit ad272c2)
dej611
added a commit
that referenced
this pull request
Mar 22, 2024
# Backport This will backport the following commits from `main` to `8.13`: - [[ES|QL] Fix wilcard complex scenarios (#178938)](#178938) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-03-21T09:19:57Z","message":"[ES|QL] Fix wilcard complex scenarios (#178938)\n\n## Summary\r\n\r\nImproves the wildcard validation logic to handle multiple occurrencies\r\nof wildcards.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ad272c2acf90598c12873d9cd731c793951f9dd2","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:ES|QL","v8.14.0","v8.13.1"],"number":178938,"url":"#178938 Fix wilcard complex scenarios (#178938)\n\n## Summary\r\n\r\nImproves the wildcard validation logic to handle multiple occurrencies\r\nof wildcards.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ad272c2acf90598c12873d9cd731c793951f9dd2"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"#178938 Fix wilcard complex scenarios (#178938)\n\n## Summary\r\n\r\nImproves the wildcard validation logic to handle multiple occurrencies\r\nof wildcards.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ad272c2acf90598c12873d9cd731c793951f9dd2"}},{"branch":"8.13","label":"v8.13.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
|
This PR didn't make it into the latest BC. Updating the labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves the wildcard validation logic to handle multiple occurrencies of wildcards.
Checklist
Delete any items that are not applicable to this PR.