Convert Aggs-based `Goal` chart to Lens `Gauge` #179489

nickofthyme · 2024-03-26T21:16:52Z

Summary

Changes the Convert to Lens functionality for Aggs-Based Goal charts that are not bucketed and have a single metric to the Lens Gauge chart.

The single metric bucketed Goal still converts to the faceted Metric in Lens until we add support for small multiples in Lens.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

markov00 · 2024-04-12T10:00:37Z

src/plugins/vis_types/gauge/public/convert_to_lens/configurations/metric.ts

@@ -14,15 +14,14 @@ import {
 } from '@kbn/visualizations-plugin/common';
 import { GaugeVisParams } from '../../types';

-export const getConfiguration = (
+export const getMetricConfiguration = (


I think is better to have tick not linked with the bands, feels more natural and clean.

Sorry @markov00, just circling back to this PR.

Can you elaborate what you mean here? This code line does not relate to your comment, are you speaking generally?

I don't remember exactly but I think I was speaking about the migration from a agg base gauge to a lens gauge (not the one to a metric that looks like in this file).
In that case, I believe we should configure the automatic tick alignment by default and not a tick aligned with the bands.

I believe that Ticks on bands is on by default only when you initially switch on the Band colors switch. but the conversion doesn't seems to enable that switch for the Agg-based Gauge, but it enables it to the agg-based Goal chart.

src/plugins/vis_types/gauge/public/convert_to_lens/configurations/metric.ts

kibana-ci · 2024-05-15T01:03:20Z

💔 Build Failed

Failed CI Steps

Test Failures

[job] [logs] Jest Tests #11 / convertToLens should return correct state for valid vis
[job] [logs] Jest Tests #11 / convertToLens should return correct state for valid vis
[job] [logs] Jest Tests #11 / convertToLens should return null if buckets count is more than 1
[job] [logs] Jest Tests #11 / convertToLens should return null if buckets count is more than 1
[job] [logs] Jest Tests #11 / convertToLens should return null if getColumnsFromVis returns null
[job] [logs] Jest Tests #11 / convertToLens should return null if getColumnsFromVis returns null
[job] [logs] Jest Tests #11 / convertToLens should return null if metric column data type is different from number
[job] [logs] Jest Tests #11 / convertToLens should return null if metric column data type is different from number
[job] [logs] Jest Tests #11 / convertToLens should return null if metrics count is more than 1
[job] [logs] Jest Tests #11 / convertToLens should return null if metrics count is more than 1
[job] [logs] Jest Tests #11 / convertToLens to Gauge should return gauge for single metric non-bucketed
[job] [logs] Jest Tests #11 / convertToLens to Gauge should return gauge for single metric non-bucketed
[job] [logs] Jest Tests #11 / convertToLens to Metric should return metric for single metric bucketed
[job] [logs] Jest Tests #11 / convertToLens to Metric should return metric for single metric bucketed
[job] [logs] FTR Configs #24 / lens app - Agg based Vis Open in Lens Goal should convert to Lens
[job] [logs] FTR Configs #24 / lens app - Agg based Vis Open in Lens Goal should convert to Lens
[job] [logs] FTR Configs #29 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens Gauge should convert color ranges
[job] [logs] FTR Configs #81 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens Gauge should convert color ranges
[job] [logs] FTR Configs #86 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens Gauge should convert color ranges
[job] [logs] FTR Configs #29 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens Gauge should convert color ranges
[job] [logs] FTR Configs #86 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens Gauge should convert color ranges
[job] [logs] FTR Configs #81 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens Gauge should convert color ranges

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`charts`	253	250	-3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lens`	1.5MB	1.5MB	+24.0B
`visTypeGauge`	8.8KB	9.2KB	+351.0B
`visualizations`	285.6KB	286.2KB	+593.0B
total			+968.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`charts`	44.9KB	45.2KB	+237.0B
`visTypeGauge`	11.2KB	11.4KB	+154.0B
total			+391.0B

Unknown metric groups

API count

id	before	after	diff
`charts`	268	269	+1

History

💚 Build #201984 succeeded f3d1d6d
💚 Build #201268 succeeded 7ca637b
💔 Build #201190 failed f2aca31
💚 Build #200723 succeeded 30fb9a5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

convert agg-based Goal chart to Lens Gauge

fc4c5f4

nickofthyme added Feature:Gauge Vis Gauge and goal visualization Feature:Lens labels Mar 26, 2024

nickofthyme requested a review from a team as a code owner March 26, 2024 21:16

nickofthyme linked an issue Mar 26, 2024 that may be closed by this pull request

[Visualize-Lens] Provide migration for Visualize Goal to Lens Gauge #179320

Open

nickofthyme added the release_note:skip Skip the PR/issue when compiling release notes label Mar 26, 2024

nickofthyme added 12 commits March 28, 2024 10:11

fix type/mock errors in get tests

767c525

fix functional test errors

c3d9528

fix serverless goal fn test assertion

7195e21

Merge branch 'main' into goal-convert-to-lens-gauge

692de7c

Merge branch 'main' into goal-convert-to-lens-gauge

39107a3

fix import error

cf8ce09

update goal functional test assertions

3cc0bba

remove unused service

2efa3d4

Merge branch 'main' into goal-convert-to-lens-gauge

011cbc3

fix more type errrors

30fb9a5

Merge branch 'main' into goal-convert-to-lens-gauge

f2aca31

Merge branch 'main' into goal-convert-to-lens-gauge

7ca637b

nickofthyme requested a review from markov00 April 4, 2024 22:55

Merge branch 'main' into goal-convert-to-lens-gauge

f3d1d6d

markov00 reviewed Apr 12, 2024

View reviewed changes

nickofthyme added 2 commits May 14, 2024 11:07

Merge branch 'main' into goal-convert-to-lens-gauge

2dc30fc

chore: migrate goal and gauge palettes to predefined Lens palettes

8daf98b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert Aggs-based `Goal` chart to Lens `Gauge` #179489

Convert Aggs-based `Goal` chart to Lens `Gauge` #179489

nickofthyme commented Mar 26, 2024

markov00 Apr 12, 2024

nickofthyme May 14, 2024 •

edited

markov00 May 16, 2024

markov00 May 16, 2024

kibana-ci commented May 15, 2024 •

edited

API count

Convert Aggs-based Goal chart to Lens Gauge #179489

Are you sure you want to change the base?

Convert Aggs-based Goal chart to Lens Gauge #179489

Conversation

nickofthyme commented Mar 26, 2024

Summary

Checklist

markov00 Apr 12, 2024

Choose a reason for hiding this comment

nickofthyme May 14, 2024 • edited

Choose a reason for hiding this comment

markov00 May 16, 2024

Choose a reason for hiding this comment

markov00 May 16, 2024

Choose a reason for hiding this comment

kibana-ci commented May 15, 2024 • edited

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

History

Convert Aggs-based `Goal` chart to Lens `Gauge` #179489

Convert Aggs-based `Goal` chart to Lens `Gauge` #179489

nickofthyme May 14, 2024 •

edited

kibana-ci commented May 15, 2024 •

edited