Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rxjs instead of rxjs/operators #179553

Merged
merged 10 commits into from
Apr 2, 2024
Merged

Conversation

afharo
Copy link
Member

@afharo afharo commented Mar 27, 2024

Summary

rxjs includes all the methods from rxjs/operators, so we could stick to using the parent one only.

Using this PR to validate if this saves any space in our humongous shared-deps asset.

  • TODO: If this actually saves some bytes, let's create an eslint rule that prefers imports from rxjs instead of rxjs/operators

For maintainers

@afharo
Copy link
Member Author

afharo commented Mar 27, 2024

/ci

@afharo
Copy link
Member Author

afharo commented Mar 27, 2024

/ci

@afharo
Copy link
Member Author

afharo commented Mar 29, 2024

/ci

@afharo afharo marked this pull request as ready for review March 29, 2024 18:15
@afharo afharo requested review from a team as code owners March 29, 2024 18:15
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-only review. Data Discovery changes LGTM 👍

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes LGTM

Copy link
Member

@wayneseymour wayneseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review of changes under src/dev/code_coverage LGTM

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES|QL editor changes LGTM

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL 👍

With RxJS v7. 2.0, most operators have been moved to 'rxjs' export site. This means that the preferred way to import operators is from 'rxjs', while 'rxjs/operators' export site has been deprecated.

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OBs UX LGTM

@afharo afharo added Team:Logstash Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Apr 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResponseOps changes LGTM!

Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logstash LGTM!

@afharo afharo enabled auto-merge (squash) April 2, 2024 15:43
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ui-shared-deps-src 46 45 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 412.1KB 412.1KB -42.0B
apm 3.2MB 3.2MB -8.0B
canvas 1015.0KB 1015.0KB -23.0B
cases 447.5KB 447.5KB -3.0B
controls 201.9KB 201.8KB -30.0B
dashboard 389.9KB 389.8KB -55.0B
data 46.8KB 46.8KB -10.0B
dataViewFieldEditor 175.2KB 175.2KB -12.0B
dataVisualizer 652.5KB 652.5KB -23.0B
discover 590.4KB 590.4KB -31.0B
fleet 1.2MB 1.2MB -2.0B
imageEmbeddable 50.3KB 50.3KB -8.0B
infra 1.4MB 1.4MB -39.0B
kibanaUtils 60.8KB 60.8KB -1.0B
lens 1.4MB 1.4MB -12.0B
links 24.7KB 24.7KB -6.0B
maps 2.9MB 2.9MB -48.0B
ml 3.7MB 3.7MB -291.0B
savedObjectsTagging 47.4KB 47.4KB -18.0B
security 579.9KB 579.9KB -4.0B
securitySolution 17.0MB 17.0MB -49.0B
slo 610.5KB 610.5KB -12.0B
spaces 175.1KB 175.1KB -1.0B
stackAlerts 82.4KB 82.4KB -10.0B
synthetics 848.7KB 848.7KB -2.0B
textBasedLanguages 151.7KB 151.7KB -10.0B
transform 391.9KB 391.9KB -9.0B
uiActionsEnhanced 135.8KB 135.8KB -10.0B
unifiedHistogram 69.5KB 69.5KB -21.0B
unifiedSearch 225.6KB 225.5KB -12.0B
ux 165.6KB 165.6KB -3.0B
visTypeTimeseries 514.3KB 514.3KB -12.0B
visTypeVega 1.8MB 1.8MB -9.0B
visualizations 274.3KB 274.3KB -3.0B
total -829.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
aiops 7.4KB 7.4KB -57.0B
apm 34.6KB 34.5KB -65.0B
bfetch 6.8KB 6.8KB -65.0B
canvas 13.5KB 13.4KB -57.0B
cases 149.1KB 149.1KB -57.0B
charts 44.8KB 44.8KB -69.0B
controls 42.5KB 42.4KB -57.0B
core 405.8KB 405.7KB -69.0B
dashboard 37.1KB 37.0KB -64.0B
dashboardEnhanced 15.4KB 15.4KB -63.0B
data 415.9KB 415.8KB -95.0B
dataViewFieldEditor 25.4KB 25.3KB -58.0B
dataViews 49.9KB 49.9KB -62.0B
dataVisualizer 23.3KB 23.2KB -65.0B
discover 34.9KB 34.9KB -69.0B
discoverEnhanced 7.6KB 7.6KB -63.0B
embeddable 65.6KB 65.6KB -87.0B
embeddableEnhanced 10.7KB 10.6KB -63.0B
expressions 98.7KB 98.6KB -84.0B
fleet 158.2KB 158.1KB -65.0B
globalSearch 6.3KB 6.2KB -65.0B
globalSearchProviders 4.9KB 4.8KB -64.0B
imageEmbeddable 8.9KB 8.9KB -57.0B
infra 102.4KB 102.4KB -67.0B
inputControlVis 8.0KB 8.0KB -63.0B
kbnUiSharedDeps-npmDll 6.3MB 6.3MB -7.9KB
kbnUiSharedDeps-srcJs 2.9MB 2.9MB -103.0B
kibanaOverview 15.1KB 15.0KB -65.0B
kibanaUtils 73.1KB 73.0KB -87.0B
lens 46.4KB 46.3KB -69.0B
licensing 9.1KB 9.0KB -65.0B
links 33.7KB 33.7KB -57.0B
logsShared 221.9KB 221.8KB -83.0B
logstash 14.0KB 13.9KB -65.0B
maps 50.5KB 50.4KB -64.0B
ml 78.5KB 78.5KB -84.0B
newsfeed 10.8KB 10.7KB -66.0B
observability 150.4KB 150.3KB -68.0B
presentationPanel 42.5KB 42.4KB -71.0B
reporting 47.8KB 47.7KB -65.0B
savedObjectsTagging 20.4KB 20.4KB -73.0B
security 66.6KB 66.6KB -67.0B
securitySolution 73.3KB 73.3KB -57.0B
slo 21.5KB 21.4KB -57.0B
spaces 24.6KB 24.6KB -65.0B
stackAlerts 24.4KB 24.4KB -57.0B
synthetics 19.7KB 19.6KB -65.0B
telemetry 19.8KB 19.7KB -65.0B
textBasedLanguages 5.6KB 5.6KB -57.0B
transform 18.6KB 18.5KB -57.0B
uiActionsEnhanced 17.4KB 17.3KB -57.0B
unifiedHistogram 6.2KB 6.2KB -57.0B
unifiedSearch 35.9KB 35.8KB -58.0B
urlDrilldown 16.5KB 16.4KB -63.0B
usageCollection 5.1KB 5.0KB -65.0B
ux 6.7KB 6.7KB -64.0B
visTypeTimeseries 18.3KB 18.2KB -57.0B
visTypeVega 33.8KB 33.7KB -65.0B
visualizations 58.9KB 58.9KB -67.0B
watcher 13.6KB 13.5KB -65.0B
total -11.7KB
Unknown metric groups

API count

id before after diff
@kbn/ui-shared-deps-src 55 54 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afharo

@afharo afharo merged commit 1c1e20a into elastic:main Apr 2, 2024
49 checks passed
@afharo afharo deleted the rxjs-over-rxjs/operators branch April 2, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:review backport:skip This commit does not require backporting Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) performance release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Fleet Team label for Observability Data Collection Fleet team Team:Logstash Team:Operations Team label for Operations Team Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet