New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ent Search] Fix connector client UI copy #179579
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
...plications/enterprise_search_content/components/connector_detail/connector_configuration.tsx
Outdated
Show resolved
Hide resolved
…ibana into delete-useless-copy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
...plications/enterprise_search_content/components/connector_detail/connector_configuration.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc links LGTM
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @leemthompo |
Fixes broken copy instructions and updates links (cherry picked from commit a381966)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.13`: - [[Ent Search] Fix connector client UI copy (#179579)](#179579) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Liam Thompson","email":"32779855+leemthompo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-04-02T09:12:33Z","message":"[Ent Search] Fix connector client UI copy (#179579)\n\nFixes broken copy instructions and updates links","sha":"a38196699eddc283b41d259c64c70b0162736ab3","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.14.0","v8.13.1"],"title":"[Ent Search] Fix connector client UI copy","number":179579,"url":"#179579 Search] Fix connector client UI copy (#179579)\n\nFixes broken copy instructions and updates links","sha":"a38196699eddc283b41d259c64c70b0162736ab3"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"#179579 Search] Fix connector client UI copy (#179579)\n\nFixes broken copy instructions and updates links","sha":"a38196699eddc283b41d259c64c70b0162736ab3"}},{"branch":"8.13","label":"v8.13.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
This PR didn't land on time of the latest BC for v8.13.1. Updating the labels. |
Fixes broken copy instructions and updates links