Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability AI Assistant] Use up / down arrows to select up to 5 previously used prompts #179696
[Observability AI Assistant] Use up / down arrows to select up to 5 previously used prompts #179696
Changes from 7 commits
fd420c6
57044c5
afb21c7
774d549
afbd1f8
28e1280
5884e63
f0d3c19
28d23fb
9115066
901e0e3
ed03491
c3760fe
25001f2
e9bed9f
4af5f4b
2709e65
bbcbdcf
0143c3d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't
onFocus
be called when theEuiInputPopover
element moves focus back to the text area? I'm assuming it does do that, and if not, should we do that ourselves? Depending on what we do on focus in the consumer of this component, maybe that doesn't matter much.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handleClosePopover
on line 89 also callsonFocus
. I removed theonFocus
here and the focus is correctly passed back to the text area.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should that also apply to
setSelectablePopoverOpen
?