[Detection Engine][FTR] Audit DE exceptions tests #179706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
reviewed
Mar 29, 2024
| @@ -90,7 +90,9 @@ FORMATTED_KB_URL="${KB_URL/https:\/\//}" | |||
| # This is used in order to wait for the environment to be ready. | |||
| sleep 150 | |||
|
|
|||
| TEST_CLOUD=1 TEST_ES_URL="https://elastic:$PASSWORD@$FORMATTED_ES_URL:443" TEST_KIBANA_URL="https://elastic:$PASSWORD@$FORMATTED_KB_URL:443" yarn run $1 | |||
| echo "uername: $USERNAME" | |||
There was a problem hiding this comment.
Hey, I'm sorry, I meant to open as draft and then I got pulled into something else. I'll clean up right now.
jbudz
approved these changes
Mar 29, 2024
yctercero
added
release_note:skip
|
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
yctercero
commented
Mar 29, 2024
|
|
||
| // TODO: When available this tag should be @skipInServerless | ||
| // This use case is not relevant to serverless. | ||
| describe('@brokenInServerless legacy investigation_fields', () => { |
There was a problem hiding this comment.
Moved to create_rule_exceptions_ess as it's not relevant to serverless.
yctercero
commented
Mar 29, 2024
| @@ -1,984 +0,0 @@ | |||
| /* | |||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | |||
There was a problem hiding this comment.
Appears deleted, but just broke this file up into prebuilt_rules.ts and rule_exceptions_execution.ts and removed some tests that were redundant.
Open
3 tasks
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @yctercero |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Continues work on #169185 and #151877 . There wasn't a ton of folder restructure, just switching the tests to run on basic license/essentials tier and some test renaming for clarity sake.
Related to #151877 this PR:
Makes note of any issues in tickets that we will need to follow up on
Related to #169185 this PR:
Things to follow up on
Flakey test runner 🟢 - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5585