Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Detection Engine][FTR] Audit detection engine rule execution FTRs #179765

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Apr 1, 2024

Summary

Continues work on #169185 and #151877 .

Related to #151877 this PR:

  • Moves FTR tests under the /rule_execution folder that do not require Platinum license into the basics folder. Tests in /rule_execution/trial_license_complete_tier folder should now relate to functionality that requires the higher license tier.
  • Rearranged some of the folder structure so that it was clear what the intent of the tests is
  • Makes note of any issues in tickets that we will need to follow up on

Related to #169185 this PR:

  • Ensures that tests are properly tagged for ESS & serverless
  • Ensures none of the tests that are critical contain the @skipInQA tag

Follow up

Edit tasklist title
Beta Give feedback Tasklist Follow up, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Project:Serverless Team:Detection Engine Team:Detections and Resp failed-test
    Edit...
  2. 8.14 candidate Project:Serverless Team:Detection Engine Team:Detections and Resp v8.14.0
    Edit...
  3. Project:Serverless Team:Detection Engine tests_needed
    Edit...
  4. Team:Detection Engine Team:Entity Analytics discuss
    Edit...

Flakey test runner - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5592

@yctercero
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

kibana-ci commented Apr 9, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test/security_solution_api_integration/test_suites/detections_response/detection_engine/rule_execution_logic/basic_license_essentials_tier/configs/serverless.config.ts / Rule execution logic Detection Engine - rule execution @ess @serverless New terms type rules with asset criticality should be enriched alert with criticality_level
  • [job] [logs] x-pack/test/security_solution_api_integration/test_suites/detections_response/detection_engine/rule_execution_logic/basic_license_essentials_tier/configs/serverless.config.ts / Rule execution logic Detection Engine - rule execution @ess @serverless New terms type rules with asset criticality should be enriched alert with criticality_level
  • [job] [logs] x-pack/test/security_solution_api_integration/test_suites/detections_response/detection_engine/rule_execution_logic/basic_license_essentials_tier/configs/ess.config.ts / Rule execution logic Detection Engine - rule execution @ess @serverless Threshold type rules generates max alerts warning when circuit breaker is exceeded
  • [job] [logs] x-pack/test/security_solution_api_integration/test_suites/detections_response/detection_engine/rule_execution_logic/basic_license_essentials_tier/configs/ess.config.ts / Rule execution logic Detection Engine - rule execution @ess @serverless Threshold type rules generates max alerts warning when circuit breaker is exceeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@@ -43,11 +43,11 @@ export default ({ getService }: FtrProviderContext) => {
const dataPathBuilder = new EsArchivePathBuilder(isServerless);
const path = dataPathBuilder.getPath('auditbeat/hosts');

// Failing: See https://github.com/elastic/kibana/issues/179704
describe.skip('@ess @serverless change alert status endpoints', () => {
describe('@ess @serverless change alert status endpoints', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to skip entire suite, just flakey tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants