[Inspector] Make Response tab faster #180035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jughosta
added
release_note:fix
Feature:Inspector
|
/ci |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
nreese
reviewed
Apr 4, 2024
src/plugins/inspector/public/views/requests/components/details/req_code_viewer.tsx
Outdated
Show resolved
Hide resolved
src/plugins/inspector/public/views/requests/components/details/req_code_viewer.tsx
Outdated
Show resolved
Hide resolved
nreese
reviewed
Apr 4, 2024
src/plugins/inspector/public/views/requests/components/details/req_code_viewer.tsx
Show resolved
Hide resolved
|
@nreese Thanks for reviewing! I refactored into using So here is a new tree structure:
|
nreese
approved these changes
Apr 4, 2024
src/plugins/inspector/public/views/requests/components/details/req_details_request_content.tsx
Outdated
Show resolved
Hide resolved
…er' into make-inspector-response-tab-faster
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @jughosta |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 5, 2024
## Summary
This PR improves the speed of "Response" tab rendering in the Inspector
flyout. The issue was that the heavy logic of building links ("Open in
Console", "Open in Search Profiler") was executed for Response tab too
although links can appear only for Request tab.
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 7a00d2e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 5, 2024
# Backport This will backport the following commits from `main` to `8.13`: - [[Inspector] Make Response tab faster (#180035)](#180035) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2024-04-05T11:05:07Z","message":"[Inspector] Make Response tab faster (#180035)\n\n## Summary\r\n\r\nThis PR improves the speed of \"Response\" tab rendering in the Inspector\r\nflyout. The issue was that the heavy logic of building links (\"Open in\r\nConsole\", \"Open in Search Profiler\") was executed for Response tab too\r\nalthough links can appear only for Request tab.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7a00d2e24b38bbdb5b41c31fe0658d78067ee679","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Inspector","Team:DataDiscovery","backport:prev-minor","v8.14.0"],"title":"[Inspector] Make Response tab faster","number":180035,"url":"#180035 Make Response tab faster (#180035)\n\n## Summary\r\n\r\nThis PR improves the speed of \"Response\" tab rendering in the Inspector\r\nflyout. The issue was that the heavy logic of building links (\"Open in\r\nConsole\", \"Open in Search Profiler\") was executed for Response tab too\r\nalthough links can appear only for Request tab.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7a00d2e24b38bbdb5b41c31fe0658d78067ee679"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"#180035 Make Response tab faster (#180035)\n\n## Summary\r\n\r\nThis PR improves the speed of \"Response\" tab rendering in the Inspector\r\nflyout. The issue was that the heavy logic of building links (\"Open in\r\nConsole\", \"Open in Search Profiler\") was executed for Response tab too\r\nalthough links can appear only for Request tab.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7a00d2e24b38bbdb5b41c31fe0658d78067ee679"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the speed of "Response" tab rendering in the Inspector flyout. The issue was that the heavy logic of building links ("Open in Console", "Open in Search Profiler") was executed for Response tab too although links can appear only for Request tab.