Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Manage loading fields at initialization #180412

Merged
merged 2 commits into from
Apr 9, 2024
Merged

[RAM] Manage loading fields at initialization #180412

merged 2 commits into from
Apr 9, 2024

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Apr 9, 2024 •
edited by kibanamachine

Summary

Fix => #175299

Checklist

@XavierM XavierM added release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) backport:prev-minor Backport to the previous minor version (i.e. one version back from main) v8.14.0 labels Apr 9, 2024
@XavierM XavierM requested a review from a team as a code owner April 9, 2024 19:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

doakalexi
doakalexi approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@doakalexi doakalexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works as expected, LGTM!

@XavierM XavierM enabled auto-merge (squash) April 9, 2024 20:34
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackAlerts 82.4KB 82.4KB +34.0B
triggersActionsUi 1.6MB 1.6MB +16.0B
total +50.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 7e22fec into elastic:main Apr 9, 2024
17 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 9, 2024
@XavierM
[RAM] Manage loading fields at initialization (elastic#180412)
9548919 
## Summary

Fix => elastic#175299

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 7e22fec)
@kibanamachine kibanamachine mentioned this pull request Apr 9, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 9, 2024
@kibanamachine @XavierM
[8.13] [RAM] Manage loading fields at initialization (#180412) (#180423)
d40410c 
# Backport

This will backport the following commits from `main` to `8.13`:
- [[RAM] Manage loading fields at initialization
(#180412)](#180412)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Xavier
Mouligneau","email":"xavier.mouligneau@elastic.co"},"sourceCommit":{"committedDate":"2024-04-09T22:29:31Z","message":"[RAM]
Manage loading fields at initialization (#180412)\n\n##
Summary\r\n\r\nFix =>
#175299
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7e22fecda9e725c020be186ceb24e6c264aa75e1","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","backport:prev-minor","v8.14.0"],"title":"[RAM]
Manage loading fields at
initialization","number":180412,"url":"#180412
Manage loading fields at initialization (#180412)\n\n##
Summary\r\n\r\nFix =>
#175299
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7e22fecda9e725c020be186ceb24e6c264aa75e1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"#180412
Manage loading fields at initialization (#180412)\n\n##
Summary\r\n\r\nFix =>
#175299
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7e22fecda9e725c020be186ceb24e6c264aa75e1"}}]}]
BACKPORT-->

Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
@lcawl lcawl added the Feature:Alerting/RulesManagement Issues related to the Rules Management UX label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doakalexi doakalexi doakalexi approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.13.3 v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@XavierM @elasticmachine @kibana-ci @kibanamachine @doakalexi @lcawl