-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAM] [Rule Form V2] Add full-page create/edit form behind feature flag to Stack Management #180539
base: main
Are you sure you want to change the base?
Conversation
…llpage # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_details.tsx
Pinging @elastic/response-ops (Team:ResponseOps) |
@JiaweiWu Re: field level validation fieldvalidation.movIt still happens, it just doesn't turn red and throw a warning at you unless you actually close the field without finishing it. |
Fixed. Using the new
There was an uncecessary regex in the duration parsing functions I ported over from triggersActionsUI. Removing this fixes the issue.
It's not an issue, the alert delay isn't a required value, though I can fix this for a cleaner UX |
Ported over in latest commit |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
## Summary Issue: #179105 Related PR: #180539 Part 1 of 3 PRs of new rule form. This PR extracts the first section of the rule form, the rule definition, from the original PR. The purpose is to fix a few bugs (Such as improving the alert delay and the rule schedule input validation), and also try to make the PR much smaller for review. The design philosophy in the PR is to create components that are devoid of any fetching or form logic. These are simply dumb components. I have also created a example plugin to demonstrate this PR. To access: 1. Run the branch with `yarn start --run-examples` 2. Navigate to `http://localhost:5601/app/triggersActionsUiExample/rule_definition` And you should be able to play around with the components in this PR: <img width="1257" alt="Screenshot 2024-05-13 at 10 10 51 AM" src="https://github.com/elastic/kibana/assets/74562234/a1ab6d96-946d-4bf6-94e2-6aa903d0b8f5"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Zacqary <zacqary.xeper@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary Issue: #179105 Related PR: #180539 Part 1: #183325 Part 2 of 3 PRs of new rule form. This PR depends on the code from part 1, so only merge this when part 1 has been merged. This PR extracts the last section of the rule form, the rule details, from the original PR. The design philosophy in the PR is to create components that are devoid of any fetching or form logic. These are simply dumb components. I have also created a example plugin to demonstrate this PR. To access: 1. Run the branch with yarn start --run-examples 2. Navigate to http://localhost:5601/app/triggersActionsUiExample/rule_details And you should be able to play around with the components in this PR: <img width="1281" alt="Screenshot 2024-05-13 at 9 44 14 PM" src="https://github.com/elastic/kibana/assets/74562234/7ca900e3-ca9a-4810-8b24-7c3ea41055d6"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Zacqary <zacqary.xeper@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Summary
Closes #179105
Rule Form V2 is now accessible from Stack Management by adding this to
kibana.yml
:Actions cannot yet be configured. These will be added in #179106 and #179107
Create and Edit
This full page form works both for creating new rules and editing existing ones. It can be accessed using the existing UI, or using the new routes
rule/create/:ruleTypeId
andrule/edit/:ruleId
.Expression validation
Error messages from the expression component affect the overall form validation.
Known broken rule types
V2 contains breaking changes for the following rule type expression components:
These should be fairly simple errors to fix, and we can include them in a further PR where we add this rule form to Observability.
Checklist
Delete any items that are not applicable to this PR.