[ObsUX] [APM] Make anomalyDetectorTypes optional

[MiriamAparicio]

Closes #180699

When we add the anomalyDetectorTypes we introduced a breaking change, not making this new parameter optional.
This PR is meant to make this parameter optional for backwards compatibility

[elasticmachine]

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[pmuellr]

I think this is the appropriate fix for the problem; checking with team before approving.

I suspect the "connector params" jest integration test to fail - you'll have to update that snapshot ... this is a new test that will catch these types of changes from now on ...

https://github.com/elastic/kibana/blob/main/x-pack/plugins/alerting/server/integration_tests/serverless_upgrade_and_rollback_checks.test.ts

run with

node scripts/jest_integration.js x-pack/plugins/alerting/server/integration_tests/serverless_upgrade_and_rollback_checks.test.ts

If that test doesn't fail, I think it means the rule type is not in the list in the module. And so should be added :-)

[pmuellr]

I think this is the appropriate fix for the problem; checking with team before approving.

Concur that this seems like an appropriate fix. Once this is live, rules that previously failed execution because of the validation should just start running again successfully.

I understand there isn't supposed to be another 8.13 patch release, but of course there could be. Seems like we should backport this to 8.13.

[pmuellr]

Another flavor that should work is this:

  anomalyDetectorTypes: schema.arrayOf(detectorsSchema, {
    minSize: 1,
    defaultValue: [],
  }),

Using defaultValue is the say as schema.maybe(), but returns the specified value if no value is passed to the validator.

This would allow you to treat the validated value as string[] instead of string[] | undefined. But I think you already have code that considers this could be undefined, so may be even more work to "fix" that.

[crespocarlos]

@elasticmachine merge upstream

[crespocarlos]

LGTM

[crespocarlos]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: da9c1b0

Metrics [docs]

✅ unchanged

History

• 💚 Build #203664 succeeded e9c276b
• 💔 Build #203583 failed da33ea3
• 💔 Build #203550 failed 0c2eb93
• 💔 Build #203515 failed 6cedb35
• 💔 Build #203296 failed 05e578f
• 💔 Build #203295 failed 67c2d35

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

[kibanamachine]

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

[kibanamachine]

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

[kibanamachine]

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.