[Oblt UX: Infrastructure and Services] Remove usage of deprecated React rendering utilities #180844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
force-pushed
the
sharedux/cleanup-tomountpoint-deprecations-iiif
branch
from
2990f2f
to
77178b7
Compare
tsullivan
commented
Apr 15, 2024
| @@ -28,7 +28,8 @@ import { AlertsStatus } from '../../../alerts/status'; | |||
| import { STANDALONE_CLUSTER_CLUSTER_UUID } from '../../../../common/constants'; | |||
| import { getSafeForExternalLink } from '../../../lib/get_safe_for_external_link'; | |||
| import './listing.scss'; | |||
| import { toMountPoint, useKibana } from '@kbn/kibana-react-plugin/public'; | |||
| import { useKibana } from '@kbn/kibana-react-plugin/public'; | |||
| import { toMountPoint } from '@kbn/react-kibana-mount'; | |||
tsullivan
force-pushed
the
sharedux/cleanup-tomountpoint-deprecations-iiif
branch
from
77178b7
to
c2b9276
Compare
tsullivan
changed the title
tsullivan
force-pushed
the
sharedux/cleanup-tomountpoint-deprecations-iiif
branch
4 times, most recently
from
99ab4dd
to
edc25a5
Compare
tsullivan
force-pushed
the
sharedux/cleanup-tomountpoint-deprecations-iiif
branch
from
edc25a5
to
85a1d56
Compare
tsullivan
added
the
release_note:skip
botelastic
bot
added
the
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.14.0
backport:skip
3 tasks
Ikuni17
pushed a commit
that referenced
this pull request
May 15, 2024
…182195) ## Summary Partially addresses elastic/kibana-team#805 These changes come up from searching in the code and finding where certain kinds of deprecated AppEx-SharedUX modules are imported. **Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.** This is the **2nd** PR to focus on code within **Observability**, following #180844. <img width="1196" alt="image" src="https://github.com/elastic/kibana/assets/908371/7f8d3707-94f0-4746-8dd5-dd858ce027f9"> Note: this also makes inclusion of `i18n` and `analytics` dependencies consistent. Analytics is an optional dependency for the SharedUX modules, which wrap `KibanaErrorBoundaryProvider` and is designed to capture telemetry about errors that are caught in the error boundary. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses https://github.com/elastic/kibana-team/issues/805
Follows #180003
These changes come up from searching in the code and finding where certain kinds of deprecated AppEx-SharedUX modules are imported. Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.
This focuses on code within Observability User Experience: Infrastructure and Services.
Checklist
Delete any items that are not applicable to this PR.