-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Oblt UX: Infrastructure and Services] Remove usage of deprecated React rendering utilities #180844
[Oblt UX: Infrastructure and Services] Remove usage of deprecated React rendering utilities #180844
Conversation
2990f2f
to
77178b7
Compare
@@ -28,7 +28,8 @@ import { AlertsStatus } from '../../../alerts/status'; | |||
import { STANDALONE_CLUSTER_CLUSTER_UUID } from '../../../../common/constants'; | |||
import { getSafeForExternalLink } from '../../../lib/get_safe_for_external_link'; | |||
import './listing.scss'; | |||
import { toMountPoint, useKibana } from '@kbn/kibana-react-plugin/public'; | |||
import { useKibana } from '@kbn/kibana-react-plugin/public'; | |||
import { toMountPoint } from '@kbn/react-kibana-mount'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 Plain JS Alert! 🚨
77178b7
to
c2b9276
Compare
99ab4dd
to
edc25a5
Compare
edc25a5
to
85a1d56
Compare
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
…182195) ## Summary Partially addresses elastic/kibana-team#805 These changes come up from searching in the code and finding where certain kinds of deprecated AppEx-SharedUX modules are imported. **Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.** This is the **2nd** PR to focus on code within **Observability**, following #180844. <img width="1196" alt="image" src="https://github.com/elastic/kibana/assets/908371/7f8d3707-94f0-4746-8dd5-dd858ce027f9"> Note: this also makes inclusion of `i18n` and `analytics` dependencies consistent. Analytics is an optional dependency for the SharedUX modules, which wrap `KibanaErrorBoundaryProvider` and is designed to capture telemetry about errors that are caught in the error boundary. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Summary
Partially addresses https://github.com/elastic/kibana-team/issues/805
Follows #180003
These changes come up from searching in the code and finding where certain kinds of deprecated AppEx-SharedUX modules are imported. Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.
This focuses on code within Observability User Experience: Infrastructure and Services.
Checklist
Delete any items that are not applicable to this PR.