Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Pipelines] Add new two columns detail layout to pipeline details page #181003

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

[Ingest Pipelines] Add new two columns detail layout to pipeline details page #181003

wants to merge 13 commits into from
+321 −119

Conversation

sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented Apr 17, 2024 •
edited

Closes #180769

Summary

This PR improves the UX of the form fields in the pipeline details page by splitting the content into two columns and better separating the processors from the optional fields required for creating a pipeline.

How to test
  • Start up kibana and es
  • Navigate to Stack management -> Ingest pipelines
  • Create a new pipeline or view an existing pipeline
  • Verify that:
    • Everything works as expected
    • Editing a pipeline name is still not allowed
Screen.Recording.2024-04-18.at.08.25.25.mov

@sabarasaba sabarasaba added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:Ingest Node Pipelines Ingest node pipelines management v8.15.0 labels Apr 17, 2024
@sabarasaba sabarasaba self-assigned this Apr 17, 2024
@sabarasaba
Copy link
Member Author

/ci

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@sabarasaba
Copy link
Member Author

/ci

@sabarasaba
Copy link
Member Author

/ci

@sabarasaba
Copy link
Member Author

/ci

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@sabarasaba
Copy link
Member Author

/ci

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@sabarasaba
Copy link
Member Author

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ingestPipelines 315 317 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 367.8KB 370.3KB +2.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@alisonelizabeth
Copy link
Contributor

@sabarasaba can this one be moved out of draft now?

@sabarasaba
Copy link
Member Author

@sabarasaba can this one be moved out of draft now?

Still have to make a few copy changes to the code examples for bulk and single index, I'll open it after I make these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sabarasaba sabarasaba

Labels
backport:skip This commit does not require backporting Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ingest Pipelines] Implement new pipeline details view layout with two columns
4 participants
@sabarasaba @kibana-ci @alisonelizabeth @kibanamachine