[Search] [Playground] SideNav: move playground to build #181087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemcelroy
added
release_note:skip
...gins/enterprise_search/public/applications/applications/components/playground/playground.tsx
Outdated
Show resolved
Hide resolved
joemcelroy
changed the title
|
@elasticmachine merge upstream |
chriscressman
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Pretty sure the changes here are why GitHub pinged me for review--LGTM
leemthompo
reviewed
Apr 22, 2024
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
sebelga
approved these changes
Apr 22, 2024
TattdCodeMonkey
approved these changes
Apr 22, 2024
leemthompo
approved these changes
Apr 22, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 22, 2024
Update Search nav to build and move playground from content to build  update the kibana side nav to feature Playground. This routes from application to playground.  --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 019dd79)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
joemcelroy
added a commit
that referenced
this pull request
Apr 25, 2024
…) (#181334) # Backport This will backport the following commits from `main` to `8.14`: - [[Search] [Playground] SideNav: move playground to build (#181087)](#181087) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Joe McElroy","email":"joseph.mcelroy@elastic.co"},"sourceCommit":{"committedDate":"2024-04-22T15:07:35Z","message":"[Search] [Playground] SideNav: move playground to build (#181087)\n\nUpdate Search nav to build and move playground from content to build\r\n\r\n\r\n\r\n\r\nupdate the kibana side nav to feature Playground. This routes from\r\napplication to playground.\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"019dd790965ac86a3bb3f49619e41430aaa89b4e","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.14.0","v8.15.0"],"title":"[Search] [Playground] SideNav: move playground to build","number":181087,"url":"#181087 [Playground] SideNav: move playground to build (#181087)\n\nUpdate Search nav to build and move playground from content to build\r\n\r\n\r\n\r\n\r\nupdate the kibana side nav to feature Playground. This routes from\r\napplication to playground.\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"019dd790965ac86a3bb3f49619e41430aaa89b4e"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#181087 [Playground] SideNav: move playground to build (#181087)\n\nUpdate Search nav to build and move playground from content to build\r\n\r\n\r\n\r\n\r\nupdate the kibana side nav to feature Playground. This routes from\r\napplication to playground.\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"019dd790965ac86a3bb3f49619e41430aaa89b4e"}}]}] BACKPORT--> Co-authored-by: Joe McElroy <joseph.mcelroy@elastic.co>
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Search nav to build and move playground from content to build
update the kibana side nav to feature Playground. This routes from application to playground.