-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HTTP/OAS] Add operation tags for APM APIs #181353
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
a735e50
to
5432e17
Compare
smith
approved these changes
Jun 12, 2024
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
HistoryTo update your PR or re-run it, just comment with: |
saikatsarkar056
pushed a commit
to saikatsarkar056/kibana
that referenced
this pull request
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
ci:project-deploy-observability
Create an Observability project
docs
release_note:skip
Skip the PR/issue when compiling release notes
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to #180056
This PR adds tags for the APM agent key and annotation APIs in the manually-maintained and automatically-generated API documents.
NOTE: I used "APM annotations" and "APM agent keys" as the tags to align with https://www.elastic.co/guide/en/kibana/current/apm-annotation-api.html and https://www.elastic.co/guide/en/kibana/current/agent-key-api.html, but if you prefer to group them all under a tag called "APM" that's okay too.
How to test
Per #181277:
yarn es snapshot --license trial
)server.oas.enabled: true
tokibana.dev.yml
yarn start --no-base-path
)