Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Alert details] - remove old flyout unnecessary z-index change #181480

Merged
merged 1 commit into from
Apr 25, 2024
Merged

[Security Solution][Alert details] - remove old flyout unnecessary z-index change #181480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions x-pack/plugins/security_solution/public/timelines/components/side_panel/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import { EuiFlyout } from '@elastic/eui';

import type { EntityType } from '@kbn/timelines-plugin/common';
import { dataTableActions, dataTableSelectors } from '@kbn/securitysolution-data-table';
import styled from 'styled-components';
import { getScopedActions, isInTableScope, isTimelineScope } from '../../../helpers';
import { timelineSelectors } from '../../store';
import { timelineDefaults } from '../../store/defaults';
Expand All @@ -36,11 +35,6 @@ interface DetailsPanelProps {
isReadOnly?: boolean;
}

// hack to to get around the fact that this flyout causes issue with timeline modal z-index
const StyleEuiFlyout = styled(EuiFlyout)`
z-index: 1002;
`;

/**
* This panel is used in both the main timeline as well as the flyouts on the host, detection, cases, and network pages.
* To prevent duplication the `isFlyoutView` prop is passed to determine the layout that should be used
Expand Down Expand Up @@ -172,15 +166,15 @@ export const DetailsPanel = React.memo(
}

return isFlyoutView ? (
<StyleEuiFlyout
<EuiFlyout
data-test-subj="timeline:details-panel:flyout"
size={panelSize}
onClose={closePanel}
ownFocus={false}
key={flyoutUniqueKey}
>
{visiblePanel}
</StyleEuiFlyout>
</EuiFlyout>
) : (
visiblePanel
);
Expand Down
4 changes: 3 additions & 1 deletion ..._solution_cypress/cypress/e2e/investigations/timelines/unified_components/query_tab.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ describe(
createNewTimeline();
executeTimelineSearch('*');
});

it('should be able to add/remove columns correctly', () => {
cy.get(GET_UNIFIED_DATA_GRID_CELL_HEADER('agent.type')).should('not.exist');
addFieldToTable('agent.type');
Expand All @@ -55,8 +56,9 @@ describe(
cy.get(GET_DISCOVER_DATA_GRID_CELL_HEADER('agent.type')).should('not.exist');
});

// these tests are skipped until we implement the expandable flyout in the unified table for timeline
context('flyout', () => {
it('should be able to open/close details details/host/user flyout', () => {
it.skip('should be able to open/close details details/host/user flyout', () => {
cy.log('Event Details Flyout');
openEventDetailsFlyout(0);
cy.get(TIMELINE_DETAILS_FLYOUT).should('be.visible');
Expand Down