[Lens] Save valuesInLegend:true as legendStats:['values'] in preparation for legend statistics
#181663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
force-pushed
the
migrate_show_values_stage_2
branch
2 times, most recently
from
00fe0c5
to
3cb1de9
Compare
2 tasks
mbondyra
added
Team:Visualizations
…paration to legend stats
mbondyra
force-pushed
the
migrate_show_values_stage_2
branch
from
3cb1de9
to
a271008
Compare
|
/ci |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To the code owners,
This PR updates the saved object of Lens with the following changes: the property
valuesInLegend: booleanis converted to the new propertylegendStats: ["values"]to accommodate displaying additional legend statistics in the future. There are no user-facing changes introduced. I have updated all saved object shapes in the code to adhere to the new structure. While the old structure will continue to function properly, this update ensures cleaner code organization.Fixes #181035 (phase 2). It's is a continuation of #180917.
In comparison to the phase 1, we've removed the conversion of legendStats to valuesInLegend which was initially added in the previous PR to ensure backward compatibility for serverless applications.